Proper date handling

Sorry for the delay.

Merely updating the patch isn't enough anymore due to the altered traversing of fields. When saving a node (insert, update) your algorithm now only saves the fields that have available exif data from the image. This is fundamentally flawed, especially when you change the picture to something with different or missing exif data. You need to loop through all available exif-enabled cck fields and set it's value to the value found in the exif header or NULL otherwise. The easiest scenario for this is when you replace the original image with one withouth exif headers. All exif cck values from the previous picture will now be stale upon updating the node. As no exif data was found, neither will any fields be updated. You need to update all fields.

If you agree with me on this I'll take a stab at a patch fixing this.

I went ahead and created this patch anyway. This patch alters the way fields are traversed as described in my previous comment. In addition, it cleans up the handling of dates. I won't repeat the reasoning in my previous comment, but the date handling requires some notes:

Proper Date field handling

The value stored for date fields are a bit more complex than those as part of the cck package. I've tested this patch for all date types in date module (date, datetime, datestamp), with all available exif date values, and it works both for node creation and update. Dates are parsed, converted and saved, all according to settings set in Date API and date field settings. Timezones are respected, date granularity is respected (exif date granularity is now obsolete and should be removed), and stored date types are respected. It's all-in-all a far more robust handling of dates than the current version.

Removed unnecessary date cleanup in _exif_reformat()

The altering of dates in _exif_reformat() was unnecessary. In the admin exif overview page it altered the presentation of dates found in the exif header. This needs no alteration. In exif_nodeapi it never ran as the $key never was found in $date_array. It was, on the other hand, duplication of code alreay found in exif_nodeapi.

Date API exif format

The exif date format (YYYY:MM:DD HH:MM:SS) is now available through the Date API, which lets you override the format exif dates should be parsed as. No immediate reason to override, but the opportunity is there. Note that this let's the administrator decide what format exif dates should be parsed as, not displayed as, so it might be more confusing than useful.

Please review this patch.

try with

patch -p1 < exif-date_api.patch

Ok, here it is, using cvs diff -du against DRUPAL-6--1. The HEAD version looks like it's for Drupal-5.x.