CyberSource module is not compatible with discount line items

Thank You for this patch, fixed (same) issue using uc_coupon.

Well it appeared working at first testing with coupons, but when processing without (using a coupon) it threw uc_order into a loop until it timed out. I did the following modify to fix that issue, it appears that count($order->line_items) does not work as expected.

Code replaced:

   for ($i = 0; (i < count($order->line_items)) && !$discount_line_items; $i++) {
     $line_item = $order->line_items[$i];
     if ($line_item['amount'] < 0)
       $discount_line_items = true;

Replaced with:

     if (is_array($order->line_items)) {
       foreach ($order->line_items as $key => $value) {
         if (($value['amount'] < 0) && !$discount_line_items)
       $discount_line_items = true;
     }

#5 indicates that the patch doesn't work properly. Need a new patch and a review before this can move forward.

It's been so long I don't remember exactly what it was, but I found more situations that caused glitches with it too, so ended up removing the whole line item part.

What I have running now that does work is removed the whole conditional section starting at line 549 and replaced with

    $purchaseTotals->grandTotalAmount = $amount;
    $request->purchaseTotals = $purchaseTotals;

Cybersource is picky about line items. by only submitting the total, it never sees the details.. nor does it have a need to know in my case anyhow.

I suppose a more elegant solution than hacking all that out would be to have an option to only submit order total, I think I have seen that in other payment modules.

Please see #1321904: CyberSource Checkout fails with UC Coupon.

Here is the patch from that issue - guess I need to post it here so it can be tested.

#9: 1321904-cybersource-negative-line-items.patch queued for re-testing.

Dunno why it failed before - didn't change anything, and the fail was in a totally unrelated area.

Looks okay to me, but needs confirmation from someone who uses CyberSource before commit.

Had some confirmation in the uc_coupon queue at #1321904: CyberSource Checkout fails with UC Coupon #4.

Committed to both branches.