The domain-specific theme settings do not seem to load properly when a site is offline. This warning is produced:

warning: Attempt to assign property of non-object in /Applications/MAMP/htdocs/drupal-6.12/includes/theme.inc on line 1816.
CommentFileSizeAuthor
#10 486370-lang.patch1.65 KBagentrickard
#9 486370-lang.patch1.46 KBagentrickard
#4 486370-language-bug.patch4.3 KBagentrickard
#3 486370-language-bug.patch4.2 KBagentrickard

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Title: Warning site is offline » Warning when site is offline
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Component: - Domain Theme » - Domain Conf

This is actually an issue with the language setting.

  $variables['language']          = $GLOBALS['language'];
  $variables['language']->dir     = $GLOBALS['language']->direction ? 'rtl' : 'ltr';

Odd. It went away while I was testing it.

Can anyone reproduce?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Title: Warning when site is offline » Locale module not handled properly
Status: Active » Needs review
StatusFileSize
new 486370-language-bug.patch4.2 KB

This is caused by some bad language value handling, especially when Locale module is disabled.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
StatusFileSize
new 486370-language-bug.patch4.3 KB

Better fix, since we have to ensure that local is enabled.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Patch (to be ported)

Committed to HEAD.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Patch (to be ported) » Fixed

Actually, this only gets ported if language support does. So closing.

jaxpax’s picture

jaxpax commented
Version: 6.x-2.0-rc7 » 6.x-2.0-rc8
Component: - Domain Conf » - Domain Theme
Status: Fixed » Active
Issue tags: +locale module

This reopened issue is a catch for a duplicate issue #497464: warning: Attempt to assign property of non-object

Hello!
I have MySQL 5
PHP 5

I have a domain: example.com and several sub domains; subdomain1, subdomain2, subdomain3, ...
1. I configured a separate theme for subdomain1 and the settings came through perfectly.

When the component Domain Theme was enabled and theme custom configured for subdomain1.example.com, I received the following error on every page in example.com and subdomain1.example.com:

warning: Attempt to assign property of non-object in /example.com/public_html/includes/theme.inc on line 1807.

2. With the Domain Theme disabled and uninstalled the warning still remain in subdomain1.example.com but NOT when visiting example.com.
3. With the Locale module enabled AND Domain theme module DISABLED the error disappeared.
4. With the Locale module enabled AND Domain theme module ENABLED the error disappeared.

It looks like I have to have the locale module turned on ;-)

Hope this is enough info?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Yes. Thanks.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs review
StatusFileSize
new 486370-lang.patch1.46 KB

Try this patch. Apply from the domain root directory. (It actually patches Domain Conf.)

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Fixed
StatusFileSize
new 486370-lang.patch1.65 KB

The following has been committed to HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -locale module

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +locale module

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.