Locale module not handled properly

agentrickard - June 9, 2009 - 14:16
Project:Domain Access
Version:6.x-2.0-rc8
Component:- Domain Theme
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Issue tags:locale module
Description

The domain-specific theme settings do not seem to load properly when a site is offline. This warning is produced:

warning: Attempt to assign property of non-object in /Applications/MAMP/htdocs/drupal-6.12/includes/theme.inc on line 1816.

#1

agentrickard - June 9, 2009 - 14:17
Title:Warning site is offline» Warning when site is offline

#2

agentrickard - June 9, 2009 - 17:42
Component:- Domain Theme» - Domain Conf

This is actually an issue with the language setting.

  $variables['language']          = $GLOBALS['language'];
  $variables['language']->dir     = $GLOBALS['language']->direction ? 'rtl' : 'ltr';

Odd. It went away while I was testing it.

Can anyone reproduce?

#3

agentrickard - June 13, 2009 - 19:10
Title:Warning when site is offline» Locale module not handled properly
Status:active» needs review

This is caused by some bad language value handling, especially when Locale module is disabled.

AttachmentSize
486370-language-bug.patch 4.2 KB

#4

agentrickard - June 13, 2009 - 19:20

Better fix, since we have to ensure that local is enabled.

AttachmentSize
486370-language-bug.patch 4.3 KB

#5

agentrickard - June 14, 2009 - 19:29
Status:needs review» patch (to be ported)

Committed to HEAD.

#6

agentrickard - June 14, 2009 - 19:50
Status:patch (to be ported)» fixed

Actually, this only gets ported if language support does. So closing.

#7

jaxpax - June 22, 2009 - 11:28
Version:6.x-2.0-rc7» 6.x-2.0-rc8
Component:- Domain Conf» - Domain Theme
Status:fixed» active

This reopened issue is a catch for a duplicate issue #497464: warning: Attempt to assign property of non-object

Hello!
I have MySQL 5
PHP 5

I have a domain: example.com and several sub domains; subdomain1, subdomain2, subdomain3, ...
1. I configured a separate theme for subdomain1 and the settings came through perfectly.

When the component Domain Theme was enabled and theme custom configured for subdomain1.example.com, I received the following error on every page in example.com and subdomain1.example.com:

warning: Attempt to assign property of non-object in /example.com/public_html/includes/theme.inc on line 1807.

2. With the Domain Theme disabled and uninstalled the warning still remain in subdomain1.example.com but NOT when visiting example.com.
3. With the Locale module enabled AND Domain theme module DISABLED the error disappeared.
4. With the Locale module enabled AND Domain theme module ENABLED the error disappeared.

It looks like I have to have the locale module turned on ;-)

Hope this is enough info?

#8

agentrickard - June 22, 2009 - 14:48

Yes. Thanks.

#9

agentrickard - June 24, 2009 - 15:09
Status:active» needs review

Try this patch. Apply from the domain root directory. (It actually patches Domain Conf.)

AttachmentSize
486370-lang.patch 1.46 KB

#10

agentrickard - June 28, 2009 - 15:28
Status:needs review» fixed

The following has been committed to HEAD.

AttachmentSize
486370-lang.patch 1.65 KB

#11

System Message - July 12, 2009 - 15:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.