Posted by agrivas on June 9, 2009 at 2:59pm
| Project: | Ubercart Auction |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
My auction setup is the following: 100 euros startting price, 5 euro bid increase and minimum increment and some large values (1000 euro and 100%) for the upper limits. If the first bidder enters a value of 5 euros, the bid is accepted and the product costs 5 euros! Did I misinterpret anything or is this a really critical bug? Has anyone else tested this scenario?
Comments
#1
P.S. The validation works perfectly from the second bidder and on.
#2
Hmm. Sorry, I can't replicate this. Might you have installed any other Ubercart add-ons which might be fiddling with the price like UC Auction does?
Has anyone else out there had a problem like this?
#3
That's true. I have several plugins installed. I also had the issue with nodewords (metatags) and I had to disable it. Is it safe to use it with only the plugins that come with ubercart?
BTW do you have in mind any common candidates that might be causing the problem?
#4
The conflict between Ubercart and Meta Tags is known; see #364682: Conflict with Ubercart / Ubercart Auction.
I have no idea what other modules may be causing this problem, though. It's pretty hard to say. Sorry.
#5
If it really is a module conflict, one way to figure out what the problem is would be to start deleting modules, either one by one or in small groups, and keep trying to place a first bid that's too low. If, after disabling a module, the problem goes away, then we can assume that that module was the source of the conflict. It's a bit of a pain, but it should help us find where the problems lie. Start by disabling the other non-core Ubercart modules first.
#6
Fisrt of all thanks for your reply. I will try to track the conflict as soon as I find some time. I will probably return with more info!
#7
I didn't manage to reproduce the behaviour as well. I did disable the Taxes module and disabled and re-enabled Fee module meanwhile, but I am not sure it has something to do with the issue. Consider it closed for now and I will get back only if I notice anything unexpected regarding the issue.
#8
Okay then.
#9
Not ok! Taxes module disabled but still same effect.
First bid is ok and every after that but .. if admin deletes all the bids then first
bidder can bid below start price!
After unchecking "This is auctioned item" and save and check again, save, set the price and now everything normal again.
#10
I think I find a bug. When admin delete all bids, they deleted from table 'uc_auction_bids' for appropriated nid, but in table 'uc_auction' the filed 'hight_bid' didn't set to 0.
Solution: In 'uc_auction.module' in line 1134 change code:
// Update uc_auction$auc_record = array(
'nid' => $node->nid,
'high_bid' => $max['bid'],
// $max['bid'] may be FALSE, which will be inserted as 0 (which is what we
// want).
);
to code:
// Update uc_auctionif (!isset ($max['bid'])) {
$max['bid'] = 0;
}
$auc_record = array(
'nid' => $node->nid,
'high_bid' => $max['bid'],
// $max['bid'] may be FALSE, which will be inserted as 0 (which is what we
// want).
);
#11
Here is patch
#12
And patch for HEAD in cvs
#13
I applied this patch but first bidder is still able to bid less than the starting price.
I do not have nodewords/metatags installed.
I have the required core modules for Ubercart 6.x-2.6 installed but none of the optional ones.
I have only the main module installed for uc_auction 6.x-1.x-dev (2011-Sep-26).
I also have ubercart adresses and product power tools installed.
I've done some playing trying to figure out any possible module conflict and have not found the issue.
I have not deleted any bids.
#14
I haven't seen issues with deleting bids, but I have seen issues with the Start Price not being respected. The attached patch is how I have fixed it locally. Love to hear any thoughts on it.
thanks!
#15
#14 works for me
#16
I also have the first bid below start price issue. We have the current (9/27/11) -dev version installed.
Tried to apply the patch from #14 and I get this error
sites/default/modules/uc_auction# patch -p0 --dry-run < uc_auction-486404-respect-start-price.patch
patching file uc_auction.module
patch: **** malformed patch at line 13: @@ -742,7 +620,7 @@ function uc_auction_nodeapi(&$node, $op,
Not sure where to go from here.
#17
I patched the file manually, with a file editor.
Try that, its just a few minutes work :)