foreach error when drawing empty queue

Posted by ryan_courtnage on June 9, 2009 at 3:52pm

Issue Summary

<?php
print nodequeue_node_titles($subqueue_id);
?>

Doing this for a queue that is empty will result in a foreach error:

warning: Invalid argument supplied for foreach() in <path>/nodequeue.module on line 2517.

nodequeue_view_nodes() should either ensure that $nodes is an array, or nodequeue_load_nodes() should always return an array.

Posted by ezra-g on June 14, 2009 at 1:14am

Good point. would you like to submit a patch for this?

Posted by Raoul Wissink on July 23, 2009 at 9:38am

Version:	6.x-2.1	» 6.x-2.3
Status:	active	» patch (to be ported)

Here you go...

Attachment	Size	Status	Test result	Operations
nodequeue-486438-1.patch	340 bytes	Ignored: Check issue status.	None	None

Posted by ezra-g on August 26, 2009 at 7:28pm

Status:

patch (to be ported)

» needs review

Marking as needs review.

Posted by ezra-g on August 27, 2009 at 4:46pm

Status:

needs review

» fixed

Committed to Drupal 5 and 6 branches.

Thanks!

Posted by System Message on September 10, 2009 at 4:50pm

Status:

fixed

» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.