Hey,
it would be nice to have a backend func which checks if a given repository is a git/svn/cvs repo when one adds a new repo/changes it's path.

Comments

jpetso’s picture

jpetso commented
Status: Active » Postponed (maintainer needs more info)

Any reason why you wouldn't want to just insert (form_alter) another validation function into the repository edit form to check it by yourself? Who knows what stuff the backend might want to validate; introducing a custom function for just one of all the possible values will probably just cause more fragmentation and unnecessary complexity imho.

Unless I have missed something important, that is.

CorniI’s picture

CorniI commented

I just thought that it would be nicer to have a backend function which can be called for all operations like fetch now, update/add repo, etc. It felt like duplicating code to form_alter for that.

jpetso’s picture

jpetso commented

"Fetch now" depends on the repository edit form being submitted (and thus validated) correctly. Update and add are the same thing technically. I'm still not convinced that an API function is a good thing here, imho we shouldn't have to check for a repository's validity after it has been successfully added or updated.

marvil07’s picture

marvil07 commented
Version: 6.x-1.0-rc1 » 6.x-2.x-dev
Status: Postponed (maintainer needs more info) » Closed (won't fix)

IMHO it should be fine to call a function that validates it from different places.