Download & Extend
Lightbox2 » Issues

Javascript error in IE8

Posted by jofje on June 9, 2009 at 6:43pm
Project:Lightbox2
Version:6.x-1.x-dev
Component:Javascript
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

When loading my site using IE8 I get the following JS error:

Webpage error details
User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)

Message: Invalid property value.
Line: 184
Char: 5
Code: 0
URI: http://app.o-festivalen.com/dp6/sites/all/modules/lightbox2/js/lightbox....

I does not get any lightbox effects clicking on images.

In Firefox I don't get any error on page loading, and the lightbox effect works well on some images (but not with others - not sure if this problem is related to the JS-error - will do some more testing before I might file separate issue...)

By the way: Images i s handled using Image Assist together with Wysiwyg/TinyMCE (all latest dev versions).

Login or register to post comments

Comments

#1

Posted by Juanzo on July 1, 2009 at 11:18pm

I have the same problem but on line 181. It works flawlessly at Firefox and Chrome. Yet, on IE8 it doesn't.

#2

Posted by Juanzo on July 1, 2009 at 11:19pm
Version:6.x-1.x-dev» 6.x-1.9

I have the same problem but on line 181. It works flawlessly at Firefox and Chrome. Yet, on IE8 it doesn't.

#3

Posted by zarouk on July 29, 2009 at 1:46pm

Hi all,

Same problem for me on IE8 on line 181.
Works fine on Firefox.

Best regards,

#4

Posted by Countzero on September 17, 2009 at 3:23pm
Version:6.x-1.9» 6.x-1.x-dev

Same problem with dev version and IE7, line 185 : 'invalid property value'.

This bug seems critical as it prevents at least some uses of the module with IE.

For example, the login functionality is totally broken : no popup and form displayed without styling in a normal window.

I also had to disable it on some pages because it prevented one custom script of mine to work.

#5

Posted by diederik_2mpact on September 18, 2009 at 1:31pm

subscribing

#6

Posted by Javier on September 20, 2009 at 11:24am

Same problem here with dev version and IE7, lightbox is not working and I get the following error message:

Line:185
Character:5
'Invalid property value'

Hope someone can help.
Thanks in advance.

#7

Posted by malphas86 on October 29, 2009 at 10:35am

I have the same problem for IE8 and IE6

Subscribing...

#8

Posted by mixman on November 1, 2009 at 4:08pm

I've tracked the problem down to the skin settings of lightbox2 - this is only an assumption, but I think that the default values for this section are invalid (empty) and jQuery is freaking out (undefined values). At least for IE7/8 of course (argh...)

Just go to /admin/settings/lightbox2 Advanced settings/ Skin settings and set the options:
- border size,
- lightbox color,
- font color
to some values (can't be empty).

#9

Posted by nilsel on November 6, 2009 at 11:21am

Thanks Mixman! Had the same problems here, setting the skin border size and colors solved it right away, now the lightbox plays without js-errors in IE 6, 7 and 8 :) I'm using lightbox2-6.x-1.9.

#10

Posted by lnunesbr on November 13, 2009 at 2:38am
Status:active» patch (to be ported)

As mixman has said, the options - border size, lightbox color and font color must be set in the admin area, if not checked, returns a js error in IE8.

I actually made some update in the "lightbox.js" to prevent that, so, it checks if the respective variables really exists:
Lightbox.borderSize
Lightbox.boxColor
Lightbox.fontColor

And checking that, if undefined variables, prevents to make an invalid js call.

version: lightbox2-6.x-1.9

thx
leandro nunes

AttachmentSize
patch-lightbox.js_.patch 832 bytes

#11

Posted by zilverdistel on February 2, 2010 at 10:34am

subscribing

#12

Posted by YK85 on March 13, 2010 at 12:53am

+1 subscribing
is there a chance of this patch being committed? thanks!

#13

Posted by chris_car on March 18, 2010 at 10:18am

I had the same problem on IE7 and IE8 and setting skin values fixed the problem! Thanks!!!

#14

Posted by joakimekroos on March 22, 2010 at 3:42pm

Skin values did the trick for me too. Thanks!

#15

Posted by yousername on April 13, 2010 at 11:36am

Skin values it is!
Thank you!

#16

Posted by jhl.verona on May 9, 2010 at 12:17am

I have just spent a frustrating couple of hours figuring this out for myself - before reading the issue queue - sigh.
I can confirm that if the Lightbox color, Font color or Overlay color are missing, then a Javascript error occurs attempting to set backgroundColor = '#' for IE 8. Firefox ignores the error.
If you understand a little Italian (or just look at the code) I've explained my debugging process here: http://www.drupalitalia.org/node/10016#comment-33975

The patch in #10, while a good start, only cures the symptom, not the illness. These values should be validated in the module form code itself - but are not (CVS version DRUPAL-6--1-9).

HTH

John

#17

Posted by jhl.verona on May 9, 2010 at 1:16am

Ok. Now I know why they weren't validated - an i18n slip and a typo. Patched against DRUPAL-6--1-9, which I think is version 6.x-1.9
(A small price to pay for such a useful module)

HTH

John

AttachmentSize
color-fix.patch 1.55 KB

#18

Posted by YK85 on May 9, 2010 at 2:10am
Status:patch (to be ported)» needs review

#19

Posted by stella on June 7, 2010 at 3:17pm
Status:needs review» fixed

patch from #17 committed, thanks!

#20

Posted by System Message on June 21, 2010 at 3:20pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#21

Posted by lovespell88 on December 4, 2010 at 5:43pm

I have found another annoying error in IE. Wonder if any of you guys encountered 'Expected identifier, string or number'. It will break all your JavaScript in IE. It's a nightmare to debug - even with Microsoft Script Debugger. And this javascript errror is only present in IE, you wouldn't have it in Safari, Opera, Chrome or Firefox