Rebuilding node_access doesn't work with flag_friend_access module

subscribe

Just a note that this will require an install file for flag_friend_access.

change to component category

How's this look? Do we need an update hook for users to run who already have this installed?

hook_nodeapi -> insert should be fine right?

I know you mentioned that you can edit a node and change the checkbox - but actually you can't currently, so insert should be fine for now I think, yes?

Ok, if that is the case, what was the reasoning for putting the check in hook_form_alter() here:

if ($form['#node']->type . '_node_form' == $form_id && empty($form['#node']->nid)) {

we should remove the last check there right? and give it a default value drawn from where? the new access table? or simply node_access? is there some node access code to use there for default value?

Here's another pass at this.

Note: I also wrote a function to determine whether or not the node has access permissions set on it or not. It needs to be modified to include og_groups access grants, but if you need to use a conditional of whether or not the node is indeed restricted to friends only, this function may help:

/**Function to check to see if access restrictions are enabled on the node**/

function flag_friend_access_check($nid) {

$sql = "SELECT realm from {node_access} where nid = '$nid'";

$result = db_query($sql);

while ($val = db_fetch_array($result)) {
foreach ($val as $key => $value) {
    $access = $value;
        }
    if ($access == 'flag_friend') {
return FALSE;
} else     {
return TRUE;
        }
    }
}

@SR -

Sure. This wasn't the main queue for placing that function, I just put it in because I was directed to this thread after I solved my own issue. I'm not an expert on this stuff.

This patch looks to flag_friend_access.install, which isn't included in either the RC or Dev release. Will the older version of flag_friend upgrade fine to this, or do I need to uninstall and reinstall?

subscribing

I have been unable to apply this patch as it's looking for a file called flag_friend_access.install.

Is there something I am missing here? I've applied numerous patches before but I always have the file it's looking for.

What should I do?

For the life of me I cannot sort out how to apply this patch. Funny, I've applied over 20 patches to my drupal install though these instructions seem to be sadly too complicated for this dumbie.

patch -p0 -i /path/to/file.patch

I've tried the method quoted above, though, since the file does not exist what file, exactly, am I supposed to point the patch to? And, where is the < that I have seen and used in every other patch that I have applied?

Put the patch file within flag_friend/flag_friend_access/

run patch -p0 -i flag_friend_486704-12.patch

This creates the flag_friend.install file and patches flag_friend_access.module

Patches are typically created in the module's root directory, but there are simply ways around it if they are not.

I did the above and the patch applied cleanly for me.

Will commit this to 1.x and 2.x

#sirkitree

Thank you very much for the instructions. I very much appreciate your patience and understanding.

I do not have access to linux commands. Is there another way to apply this patch?

#dudeoflife

Is you site hosted on a linux/unix box (pretty much the standard for a drupal site)? If so I am guessing that you are using a windows based computer yourself? If you are on windows and you need to access the command line on a hosted site you can always install an ssh tool such as Putty.

After you install putty, and do a little reading of the manual, you will find that you can ssh into your site and apply the patch.

If you regularly use ftp for your files you are really going to enjoy the putty client because the file transfers of modules and patches from drupal.org are oh so much faster.

Make sure that you investigate the pageant program that comes with putty because it can make the logins much easier that having to type in your login information all the time.

Hope this help you out!

@sirkitree,

your post #23.

What is your problem to include the available patchcode in the actual contributed module releases?

Please read my post http://drupal.org/node/484394#comment-2742126

The actual contributed releases of flag friend access module are bad. Very bad.
So bad because they do not work. To do something is not good for Drupal. It is not good for the reputation of Drupal.

@sirkitree, I will watch you and the flag friend access module .

LOL, srsly? Are you like threatening me quiptime?

@Scott Reynolds,

the contributed code of flag friend access module is not marginally broken - it is completely broken.

@sirkitree,

I want to threaten anybody. I want that works the module.

Please remember, you are a member of Lullabot. Is that the modus operandi of Lullabot - to contribute broken modules?

Why do not you just answer my question?

@quiptime: have you tried this patch? are you saying it is still broken after this patch is applied? if so, can you please provide some constructive feedback? I've not gotten to committing this just yet because I've been busy working for Lullabot.

Not the patch code has bugs. I did not say that. The contributed code has bugs. The errors are known and a solution is there.
But the solution is not available in the contributed modules. That is what I criticize.

The (errors) bugs are so obvious that one not a specialist must be seen to them. You simply try to use the module. And that's what I did.

Next, I looked at the code of the contributed module versions. And pardon me, but this is little bit stupid:

if ($form['#node']->type . '_node_form' == $form_id && empty($form['#node']->nid))

That is not logical. What do you if you later at a node might change the friend access?

$form['flag_friend_control']['flag_friend_access'] = array(
  '#type' => 'checkbox',
  '#title' => t('Only My Friends'),
);

What is it? No default value.

=========================================================

I need this module. But it must work. I will test the patch and report constructively. Is that OK?

Hey quip-

May I suggest for you to rework the module? I mean, the code is all right here. It IS open source, you know. Maybe you have more spare time than these other cats who bang out line after line of code for these broken modules.

#kewlguy

I don't think I would be able to do that with my shared hosting plan thru hostgator. However, if I am wrong, the implications of this program could be huge- as in setting up a ffmpg service.... Thanks for the heads up, in any case.

Is flag_friend_access supposed to have no index in the database? When I look in my site docs I see a warning for " Indexes: No index found". Is this correct?

So in other words: don't mess this this latest patch?

#dudeoflife

I installed the module, then applied the patch, of which there are instructions in the above posts and then I went into my tool for mysql and confirmed that the table exists, then while viewing the structure of the table "flag_friend_access" and looking to the row for "nid" I clicked on the icon that has the screen tip for "Primary Key" and it made the last fix for me.

TIP: I use cpanel to get to myphpadmin for mysql. ** ALWAYS MAKE A BACK UP **, It's in cpanel as well, or plesk whichever you have on a hosted set up. If you use a Mamp or Lamp set up on your computer is should not be too hard to find in the set up.

This is not the actual method that many programmers would use it is more of an administrators way of solving a problem without digging into the module install file and making the change and submitting a patch. PHP and creating myql scripts are way beyond my thinking style so it is the way I find I go.

Having said all that you can look into a search for 'drupal+create a module' and in the handbooks, I saw a decent tutorial here to see how to make what appears to be a simpler change to the module.install file.

You could always do a search for the latest handbook page using the terms "create a patch" and you may find that it is a very viable way to contribute back for all the awesome 'free' code here.

Or, do similar to what you said and "don't mess with this module", kewl?

Thank you for contributing!

Ok, added the index this should be good now.

committed to 1.x-dev: http://drupal.org/cvs?commit=345698

porting to 2.x-dev

committed to 2.x-dev: http://drupal.org/cvs?commit=345708

Thanks again for the explanation, kewlguy!

I'm gonna dig in learn more about this here concept of patching. I am very comfortable working with php as well as mysql scripts-- this concept of using shell commands is a whole new concept with me.... I gather that it does to code what I like to do manually. Really interesting and powerful stuff.

As far as this patch is concerned, I'll give it a go as and post the results on this thread. Soon, hopefully.

Free the software!