This may be a similar issue to 47413, but is different because I'm using all the latest Drupal system files from CVS - in other words, post-4.7-beta4.

The problem seems to be two-fold but the two issues may be related. The attached screenshot shows four blocks that are (or, at least, used to be!) blockbars: Main menu, Members, Events and Forums.

However the menu items no longer appear as blockbar blocks and are not even hyperlinks any more.

The second side of the problem (or is it a seperate problem?) is that the page load time has increased dramatically.

Unfortunately, there are no errors showing up in the watchdog so I have no idea how to proceed with tracking down the bug.

Any help would be greatly appreciated!

Regards

Patrick

CommentFileSizeAuthor
drupal_screenshot_sample_5.png170.24 KBPatrick Nelson

Comments

dreed47’s picture

dreed47 commented

I'm going to need more info to be able to help you. I downloaded the latest drupal core CVS as of 15 minutes ago and tested the current CVS version of the BlockBar module on the bluemarine theme and I did not see the problems you mentioned. The blockbars work fine and I did not notice any performance issues.

I see you've done some theming of the blockbars. You need to make sure that you still have the appropriate div tag ID and class attributtes on your themed versions for the blockbars to continue to work. You may want to revert back to bluemarine and try it to make sure the core blockbar code still workes with your Drupal install. If it does then my gues is you may have inadvertantly removed an atttribute tag when you themed the blockbars.

Patrick Nelson’s picture

Patrick Nelson commented

der,

Sorry. Should have been clearer. As of about four hours ago, the theme I was using (slightly customised Fancy theme) was working fine with Blockbar. I decided to upgrade the Drupal system files because the event module wasn't working properly and updating that module would only work if I updated the system modules (unrecognised base_path).

Hence the "upgrade" which "broke" BlockBar and caused really slow page uploads. But the theme WAS working fine with BlockBar prior to that. Here is a list of files that I have updated:

/includes
bootstrap.inc - to 1.86
common.inc - to 1.514
database.mysql.inc - to 1.50
database.mysqli.inc - to 1.13
form.inc - to 1.66
locale.inc - to 1.65
menu.inc - to 1.105
theme.inc - to 1.283
unicode.inc - to 1.15

/misc
drupal.css - to 1.140
upload.js - to 1.6
update.js - to 1.5
progress.js - to 1.7
drupal.js - to 1.19
collapse.js - to 1.3

/modules
block.module - to 1.200
blogapi.module - to 1.74
book.module - to 1.348
comment.module - to 1.429
forum.module - to 1.309
locale.module - to 1.132
menu.module - to 1.66
node.module - to 1.599
page.module - to 1.152
profile.module - to 1.132
search.module - to 1.161
statistics.module - to 1.218
story.module - to 1.84
system.module - to 1.288
taxonomy.module - to 1.258
throttle.module - to 1.58
tracker.module - to 1.126
upload.module - to 1.73
user.module - to 1.580

/themes/fancy
page.tpl.php - to 1.3

/themes/engines/phptemplate
phptemplate.engine - to 1.26

I have a number of other contrib modules installed, the most relevant being:
controlpanel
insert_block
recent_blocks
views

But the pages don't work even if I switch these off.

dreed47’s picture

dreed47 commented

Did you do a full refresh of ALL the core Drupal files? Did you update your database accordingly?

My goal is a working BlockBar module that is compatible with each successive 4.7 release (beta and final), not necessarily compatible with CVS HEAD since HEAD is such a fast moving target (although it appears to be working fine with HEAD at the moment).

Not sure what to tell you but if I were in your shoes I would do another refresh from CVS and ensure you have a complete set of files and then run the upgrade to update your database. I would then disable all contributed modules except BlockBar and then test the BlockBars with bluemarine theme first. That should give you exactly what I just tested on my machine. If that works you can then enable your other modules and theme testing as you go to see if one of them broke the BlockBars.

scott_dft’s picture

scott_dft commented

I'm fairly sure this is all to do with the changes in the base for all URLS (now all URLs should be relative from the host, i.e. start with a /).

My test site went pear shaped the other day, Firebug for Firefox (very handy extension) was showing a lot of broken CSS. But latest CVS seems to have fixed the lot.

Patrick, I would try latest CVS and see how it looks now.

Der, it seems the preferred method of adding CSS sheets is something like

$the_path = drupal_get_path('module', 'blockbar');
theme_add_style($the_path .'/blockbar.css');

What do you think?

Scott

dreed47’s picture

dreed47 commented

You may be right Scott. I have not yet reviewed any of my 4.7 modules for impacts regarding the base URL issues in core. This should be easy enough for Patrick to test if he's running FireFox with the web developers extention.

Patrick, can you view the source of your page and see if the blockbar.css and blockbar.js files are getting included in the page?

scott_dft’s picture

scott_dft commented

Actually I've just had a better look and any module CSS is broken if it doesn't use theme_add_style() or add $base_path manually.

The javascript is ok because drupal_add_js() has been updated to add the base.

Der, you maintain Control Panel as well, don't you? Another that needs updating.

S.

Patrick Nelson’s picture

Patrick Nelson commented

der,

Patrick, can you view the source of your page and see if the blockbar.css and blockbar.js files are getting included in the page?

Have followed your earlier instructions - things haven't really changed so I revisited this post and I can confirm in response to above question, no, they are not!

Any ideas?

dreed47’s picture

dreed47 commented
Assigned: Unassigned » dreed47

Okay, I've changed the code to use theme_add_style() to add the style sheet. Let me know if this fixes the issue.

Patrick Nelson’s picture

Patrick Nelson commented

Yep, perfect - that's done the job.

Many thanks for your help der - and scott.

Now, where did I put that database backup....?

dreed47’s picture

dreed47 commented
Status: Active » Fixed
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)