On the main admin/filters page, I believe the entry in the "Roles" column of the table should always read "All roles may use this format". Currently the entry tells you which roles would be able to use the format if it were not selected as the default.

Here is a trivial patch to correct this.

CommentFileSizeAuthor
#8 all_roles_default_format_3_0.patch1.16 KBCrell
#6 all_roles_default_format_3.patch3.1 KBRayZ
#5 all_roles_default_format_2_0.patch1.94 KBRayZ
all_roles_default_format_patch.txt1.13 KBRayZ

Comments

RayZ’s picture

RayZ commented

Just to be clear ... I'm referring to the row of the table selected as the default input format.

RayZ’s picture

RayZ commented
Priority: Minor » Normal

Bumped up priority, since the issue is incorrect info in the UI and the fix is so trivial.

Crell’s picture

Crell commented
Status: Needs review » Needs work

I can see where the current text is misleading, but I don't think the fix is any less misleading. The roles column means "these roles can optionally select this format". By changing it to read "All roles can ...", it gives the impression that the listed format can be used by anyone, period. It still doesn't make it clear that the *reason* anyone can use it is that it's the default.

I would recommend adding a line to the help text above the table instead to read something like "Note that whichever format is marked default will be available to all roles". That keeps the displayed information accurate and makes it clear that the default is available to everyone.

RayZ’s picture

RayZ commented
Status: Needs work » Needs review

Good points. Here's an updated patch.

I changed the help text ...

Below you can configure which input formats are available to which roles, as well as choose a default input format (used for imported content, for example).

... to say ...

Below you can configure which input formats are available to which roles, as well as choose a default input format (used for imported content, for example) which is available to all roles.

I also changed the text from my original patch from "All roles may use this format" to "All roles may use default format" (without the underlining, of course). This should clarify the reason.

It wasn't clear to me whether your were suggesting the change to the help text in addition to or instead of the original patch. I still think it is important to change the text in the role column to reflect which roles can "use" the format as opposed to which roles can "optionally select the format if it were not the default". Seems much more straightforward and consistent with the way "use" is currently employed in the "No roles may use this format" message.

RayZ’s picture

RayZ commented
StatusFileSize
new all_roles_default_format_2_0.patch1.94 KB

Argh. Never work on submitting two issues at once. I attached the patch and previewed this one. Then I wrote and submitted another issue in another window of my browser and it stole this patch!

RayZ’s picture

RayZ commented
StatusFileSize
new all_roles_default_format_3.patch3.1 KB

OK, while I'm clarifying the help on this page, I decided to include some additional text that clarifies the "admins can use all formats" issue as well, rather than re-opening that issue with a separate patch.

Here's an updated patch to replace the previous ones.

dries’s picture

dries commented

Looks good to me. Feel free to RTBC this after another review.

Crell’s picture

Crell commented
StatusFileSize
new all_roles_default_format_3_0.patch1.16 KB

Actually I'd meant to put in the header instead of modifying the table. In the table, you want to know what the format is actually configured for. If you change the labeling, then you don't know what it's actually set for unless you edit it directly or change the default format.

I also think that it is a large enough issue to warrant a line all on its own rather than just a dependent clause within the existing paragraph. It's too easy to miss that way. :-)

See attached patch, which simply adds one extra one-sentence paragraph to the header text.

RayZ’s picture

RayZ commented

Please use the patch from #6 (the one Dries said looks good to him) as opposed to #8.

@Crell: You apparently missed my patch in followup #6 under this issue. It *does* separate it out into a new paragraph and adds some additional text to clarify the other issue I referenced in that followup, which is missing from your patch.

And I disagree about not needing to modify the table. It is better to have the info in the table be consistent with the explanatory text above it than to have the text explain why the information in the table does not mean what it says.

E.g. Filtered HTML, set to default, will typically say "No roles may use this format", which is just incorrect. "All roles may use default format" clearly communicates both who can use it and why.

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

Dur. OK, yeah, I missed #6. Sorry about that. I like the header text in #6, but I still don't like overriding the text in the table, for reasons I've already stated. It's not a giant issue, though.

@Dries: Setting RTC for #6, with or without the alteration of the table text. Your call here. Both views are documented above.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Reviewed & tested by the community » Fixed

applied

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)