Integration with Fusion Charts V 3 (paid-for package).
| Project: | FusionCharts |
| Version: | 6.x-1.x-dev |
| Component: | FusionCharts core |
| Category: | feature request |
| Priority: | normal |
| Assigned: | aaron1234nz |
| Status: | reviewed & tested by the community |
Here's a patch for integration with the paid commercial package. V3 comes in a folder called "FusionCharts" instead of "FusionChartsFree".
Changelog:
1) Changed the .info file to "Integration with Fusion Charts" instead of "Integration with Fusion Charts Free"
2) Modified hook_requirements to check for both the free package and the commercial package and report status as appropriate.
3) It now calls a new function _fusionchart_get_package($reset = FALSE) which performs the scan and returns the package.
4) Change the theme_fusionchart function to call above function and call theme_fusionchart_free() or theme_fusionchart_commercial() as appropriate (two new functions).
5) Added in a section to fusioncharts_data() to build XML for the style properties that are only supported in Fusion Charts paid for package.
I have designed the patch with backwards compatibility in mind so that existing users won't have to touch their settings. Are you putting new development into a 2.0 branch?
This patch also includes my removal of the line breaks as I mentioned in the last issue.
Thanks!
#1
#2
Aaron, if you email the creators of Fusion Charts and tell them that you've spent hundreds of hours working on Drupal integration, they would probably be GLAD to give you a free license for V3.
They would be very silly not to, since you are supporting their work for free.
;)
#3
Oh yes, the new functionality with regards to choosing a package (free or commercial) works as follows:
1) The module will scan the directories and save either "free" or "commercial" using variable_set.
2) If the user switches to the other one, they can visit the status report page, where hook_requirements() is called. This will force a rescan of the directories.
I implemented this to prevent a rescan being done every time theme('fusionchart') is called.
#4
New patch which sorts out a small issue...
#5
Thanks for that Mark,
You look to have done a very good job. I'll review the patches, test and commit early next week.
I'll also contact the makers of FusionCharts and get a copy of the paid version so I can test. I have talked with the creator in the past and they are very keen on this project and are willing to help out where they can, however I didn't have the time to integrate with the paid version at the time so turned their offers.
I know there are number of people who will be very interested in the patch you have provided.
Aaron
#6
Hi Aaron, have you had a chance to look further into this? Thanks!
#7
Hi Mark,
thanks for the patch. Sorry it took so long for me to commit it. I have done so now.
There are a few things that need looking at still (eg there are couple of chart styles are are only in the free package and a couple only in the paid package. I also need to update the documentation.
leaving issue open and assigning to me.