Every hour calculation is wrong

Posted by fred0 on June 10, 2009 at 11:06pm

Issue Summary

I was looking through the module code to add an option to limit submissions to 1 per month and found that the setting for every hour was wrong. It was set to 1600 when 60 * 60 = 3600.

Also, I'd like to suggest adding an every month option. Since figuring out what month it is to get the number of days seems unnecessary, I'm thinking of standardizing on a 30 day period like this:

'2592000' => t('every month (30 days)'),

Comments

#1

Posted by fred0 on November 8, 2009 at 10:04pm

Version:	6.x-2.7	» 6.x-2.9
Priority:	normal	» critical

Just realized that this bug persists in the latest release. Here's a patch. Hopefully this can get fixed asap!

Attachment	Size
webform.module.patch	565 bytes

#2

Posted by quicksketch on November 8, 2009 at 10:50pm

Priority:	critical	» normal
Status:	active	» needs review

Thanks the hour fix is definitely necessary. The month feature should be done separately. I believe there has been a request in the past to support calendar weeks/months. Critical bugs are reserved for bugs that render Webform completely inoperable.

#3

Posted by fred0 on November 8, 2009 at 11:05pm

How do mean separately? As a new issue with patch?

#4

Posted by quicksketch on November 9, 2009 at 12:33am

I'd suggest splitting out the change and making a new issue yes. However I'm not keen on adding an option for "month (30 days)", since its no different than just entering "[ 30 ] [ days ]" from the existing options. If you're interested in supporting calendar months/weeks, I'd be happy to see that added to #597438: Limit submission by Calendar Week and Month.

#5

Posted by fred0 on November 9, 2009 at 12:44am

Ok, can do on a new issue.

However, the existing option in v2.9 says:
Limit to [X] submission(s) [period]
Given that, entering [30] and setting days would limit to 30 submissions per day and not [X] submissions every 30 days.

#6

Posted by quicksketch on November 9, 2009 at 1:13am

Ah fair enough. I realized some people might also want to make hours or days work by calendar dates also (resetting at midnight or at the top of the hour for example), so making a special option just for week and month might not be satisfactory. We'll need to think out these problems in #597438: Limit submission by Calendar Week and Month.