Validating Arthemia at http://d-theme.com/arthemia.

The following line has a block level element, div, insidean inline element, link. Change the div to span.
<div id="logo"><a href="/" title="D theme for da Web"><div id="sitename">D theme for da Web</div></a> </div>

The following line has a block level element, ul, inside an inline element, span. Change the span to a div.
<span class="terms terms-inline"><ul class="links inline">

Target is not a legal attribute for links in XHTML 1.0 Strict.
<a href="http://michaelhutagalung.com/2008/08/arthemia-20-released-the-updates/" target="_blank">Arthemia</a> theme by <a href="http://michaelhutagalung.com" target="_blank">Michael Hutagalung</a>

Comments

peterx’s picture

peterx commented

The CSS validates as CSS 3 and has one error when validated as CSS 2.1.

URI : http://d-theme.com/sites/all/themes/arthemia/style.css?n
573 Unknown pseudo-element or pseudo-class :last-child
naheemsays’s picture

naheemsays commented

I have fixed the first two errors, as for the third I am thinking it may be best to leave it as the alternative is javascript and I am not a fan of that atleast in this instance. Opinions?

As for the css, it is needed for nested menus.

Thanks.

peterx’s picture

peterx commented

I can live with CSS 3 only and added a comment for people looking at the theme who might want compatibility with older browsers.

I am not a fan of pop up links unless they are clearly styled to indicate the pop up. I suggest the => symbol if you keep the pop ups. Javascript is ok. You could start with a plain link and the external site symbol then use Jquery both to create the pop up and to add the appropriate styling. It will work in a nice way with and without Javascript.

I do dislike having a link to an external site for updates instead of the Drupal project. If there is something important at michaelhutagalung.com/2008/08/arthemia-20-released-the-updates then it should be a link from drupal.org/project/arthemia.

naheemsays’s picture

naheemsays commented

I do dislike having a link to an external site for updates instead of the Drupal project. If there is something important at michaelhutagalung.com/2008/08/arthemia-20-released-the-updates then it should be a link from drupal.org/project/arthemia.

So do I, but that link is acknowledgement that I did not create the theme - just ported it from wordpress and the original theme had that link. I also see such links on other themes to I assume its not considered polite to remove them?

peterx’s picture

peterx commented

Change <a href="http://michaelhutagalung.com/2008/08/arthemia-20-released-the-updates/" target="_blank">Arthemia</a> to <a href="http://drupal.org/project/arthemia">Arthemia</a> because that is where Drupal users get the theme and updates. Leave the author link intact. People usually add themselves:

<a href="http://drupal.org/project/arthemia">Arthemia</a> ported by the incredibly handsome, intelligent <a href="http://www.theraggedyedge.co.uk/">Naheem Zaffar</a> from the Wordpress theme by <a href="http://michaelhutagalung.com">Michael Hutagalung</a>

naheemsays’s picture

naheemsays commented
Status: Active » Fixed

lol at the self promotion. :) I think I am doing enough by hosting a theme demo site that is amply linked to!

fixed in http://drupal.org/cvs?commit=224980

peterx’s picture

peterx commented
Status: Fixed » Needs work

One last fix. With the bottom link changed, this theme validates as XHTML 1.0 Strict plus US 508 and WCAG at level A. The validator now reaches level AA validation and highlights the following problem. The link in the footer uses the same text as one of the menu entries. A title is the WCAG recommendation to explain the difference. Pergaps title="Download this theme from""
WCAGv1 13.1 (AA) Use the 'title' attribute to distinguish between different links that use the same link text:
<a href="http://drupal.org/project/arthemia">Arthemia</a>