Validation at http://d-theme.com/genesis:

This theme has some HTML errors. The following line has a link inside a link.
<a href="/" title="Home page" rel="home"><a href="/" title="Home page" rel="home">D theme for da Web</a></a>

This theme fails as WCAG (WAI) at level AA with an improperly nested heading.
<h2 class="block-title">User login</h2>

Validation as CSS 3 produced the following error.

URI : http://d-theme.com/sites/all/themes/genesis/genesis/css/base.css?n
164 ul.secondary li Value Error : list-style 0 is not a list-style-position value : 0

Validation as CSS 2.1 produced the following errors.

URI : http://d-theme.com/sites/all/themes/genesis/genesis/css/base.css?n
85 Unknown pseudo-element or pseudo-class :last-child
85 Unknown pseudo-element or pseudo-class :last-child
164 ul.secondary li Value Error : list-style 0 is not a list-style-position value : 0

Comments

Jeff Burnz’s picture

Jeff Burnz commented

The link in a link, no idea peterx, that appears to be an artifact of your installation of the theme or your site. The theme should look like this:
http://adaptivethemes.com/starter-themes/?theme=genesis_SUBTHEME

Unfortunately I can't make the assumption that users do not want a headings on leaderboard region blocks. So it fails because of the way the end user has set it up:)

list-style: 0; ekk!, thanks for pointing that out, appears the compression script I used switched out "none" for "0", bloody hell, thats not good. If you look in genesis/genesis/css/uncompressed/base.css you'll see its list-style: none (line 828).

I have stated many times I am more than willing to use CSS3 if possible, after all. its 2009 and lets use the technology if possible. I'm sorry, but pointing out that at theme fails CSS2.1 when it's using CSS3 is silly, its as silly as pointing out that a theme fails XHTML when the doc type is HTML 4. What exactly are you expecting here - that we stick to using CSS2.1 forever?

So:

link/link - no idea, looks your site is doing something weird
Leaderboard region block h2 - wont fix
CSS3 - wont fix
list-style: 0; fixed!

BTW, there is a spelling error on the Genesis page in your site (misspelled the theme name) and your installation is very broken. Please be aware that the prestyled subthemes (such as Cold Day) are not compatible with the Genesis 6.x-2.x version of this theme.

peterx’s picture

peterx commented

That double link is weird because it does not happen in any of the other 300+ themes. I added diagnostic prints to:

function genesis_preprocess_page(&$vars, $hook) {

print '<p>1' . htmlentities($vars['site_name']) . '</p>';
  if (!empty($vars['site_name'])) {
    $vars['site_name'] = '<a href="'. $vars['front_page'] .'" title="'. t('Home page') .'" rel="home">'. $vars['site_name'] .'</a>';
  }
print '<p>2' . htmlentities($vars['site_name']) . '</p>';

The following output suggests the function runs twice.

1D theme for da Web
2<a href="/" title="Home page" rel="home">D theme for da Web</a>
1<a href="/" title="Home page" rel="home">D theme for da Web</a>
2<a href="/" title="Home page" rel="home"><a href="/" title="Home page" rel="home">D theme for da Web</a></a>

Does your theme work with the sections module? I tell Drupal the name of the page theme using the same technique.

Jeff Burnz’s picture

Jeff Burnz commented

I don't know about the sections module, I'll try it, hopefully later to day.

BTW, is that the core Genesis theme you have enabled, because if it is you should disable it, its not really meant to work as a standalone theme, only the subthemes should be enabled (base themes don't need to be enabled for subthemes to work).

peterx’s picture

peterx commented

The core theme is enabled and displayed for a lot of the themes where the core theme does not produce a usable display. What I might do for your theme is take your core theme out of the normal display and have a link from the subthemes to the core theme display so people can see the starting point. Validating the core theme still makes sense because people may not override a broken part.

If you have menus that do not work without specific CSS in place in the subtheme, there will be someone who leaves the CSS out then ends up with a broken site. You then have to explain how to access admin without using the menu and how to set Garland as the admin theme. If the base theme makes a usable and valid page then subtheme builders can leave out vital bits and still have a working theme.

As an example of a base theme error, Zen produces one error that appears in almost every theme based on Zen. If Zen fixed just one line in their code, about 20 themes would instantly validate all the way up through WCAG to level AAA.

Jeff Burnz’s picture

Jeff Burnz commented
Status: Active » Closed (fixed)

Genesis SUBTHEME is the starting point, not the core theme. Same with Zen, Zen is not the starting poing, the STARTERKIT is the starting point. Genesis base theme, just like Zen, is never meant to be enabled and actually used.

Its not a CSS issue as you think, but a template issue. Genesis works differently than every other subtheming starter theme out there, it flips the notion that subthemes should only be CSS, and instead subthemes are where all the templates live, not in the base theme. This is a paradimatic shift in the concept of subthemes.

Validating the subtheme is the same as validating core, you get all of the core CSS when you validate the subtheme. Theres no point in having core enabled, even for validation purposes.

Its simply not possible to unset crucial CSS unless you deliberatly unset them in the info file, or use the stylestripper module. This theme is not like Zen where there are 17 steps to set up a subtheme, its copy/paste enable, done.

Jeff Burnz’s picture

Jeff Burnz commented
Status: Closed (fixed) » Active

weird, it closed it, hmmm

peterx’s picture

peterx commented

I changed the description of Genesis and Genesis SUBTHEME. Genesis is now just a link off Genesis SUBTHEME. You can see the description of Genesis SUBTHEME at http://d-theme.com/genesis_subtheme.

Jeff Burnz’s picture

Jeff Burnz commented
Status: Active » Closed (fixed)

I don't get why you are doing this, very strange indeed, I just told you its not meant to be enabled and you get all the base themes resources when you validate the subtheme. So whats the point in enabling it?

Really I'd prefer it if you just removed all the Genesis themes, not only are they set up badly, you are running two incompatible versions which breaks the prestyled subthemes. I can't see how that does end users any favors.

Closing, this is not going anywhere.