There are two modules to add links in the sitemap that other XML sitemap modules don't add; what is the difference between them, and what is the purpose of having two different modules to do the same thing in different ways?

Comments

dave reid’s picture

They do simply what the modules say they do in their respective .info files. XML sitemap menu is for adding menu links. Instead of creating a new xmlsitemap 'custom' menu for adding custom paths that are not nodes, taxonomy terms, users, or menu links (e.g. panels, etc), I have added a short module xmlsitemap_custom.module that if you only need to add custom links, it has much less overhead than xmlsitemap_menu.module.

If a user wants to add custom link (like panels) it's much easier to explain (hey just enable the xmlsitemap_custom module) instead of, you need to create a new menu link and add it to this custom menu you didn't know existed, and if you ever want to change it then you have to dig in the menu administration and find it again.

avpaderno’s picture

XML sitemap menu can be used to add links that a module puts in a menu, while XML sitemap custom can be used to add arbitrary links into the sitemap.
I keep to forget modules can create their own menus, and I would rather prefer to use the already existing menu links than to copy the menu links defined from that module manually in the XML sitemap custom settings page.
I can enable both the modules, enable just one of them, or not enable them at all.

Thanks for pointing this out; this answer to my question.

EDIT: if I would get used to this keyboard, which is different from the Italian keyboard I normally use, I could avoid some of the typos I do.

dave reid’s picture

Status: Active » Fixed

Yep that's correct. Plus, with the xmlsitemap_custom module we do all the extra validation like "hey this can only be an internal drupal path" or "this is not accessible to anonymous users, it can't be in the sitemap". If a user were to put these 'custom' links in a menu for xmlsitemap_menu to pick up, they just wouldn't show up in the sitemap and the user doesn't see why. They can see why when using the xmlsitemap_custom module.

avpaderno’s picture

Also, it makes sense having both the modules included in the XML sitemap project because they are little modules, and creating a different project just for them is not something desirable.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.