Block "Mutual Friends" doesn't work any more

bensemmel - June 11, 2009 - 17:50
Project:FriendList
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active
Description

Hi Merc,

after your latest commits the "mutual friends" block don't show up any more. I activated it again in the block settings but it doesn't appear on the userprofile sites nor on nodes of other users where the y show up before.

The "people you might know block" still works.

Regards
Ben

#1

mercmobily - June 13, 2009 - 13:12
Status:active» fixed

Hi,

OK, as a matter of principle, fixed this on the spot. Please confirm that it works...
It was a real bugger to fix, this one. But I fixed it the right way...

By the way expect the outstanding bugs to get resolved very soon (hopefully this week) and version 1 of the module to be out... which is great. Way to go... I am just sorry about the module being on hold for 4 months, it was ever so close to version 1...

Merc.

#2

bensemmel - June 14, 2009 - 12:13
Status:fixed» active

Hi Merc,

thank you for working on this so quickly...

The "Mutual friends" Block now shows correct results again, but it also shows the logged-in user as well as the user whos profile or content is viewed.
In my opinion these two should be excluded again.

Regards,

ben

#3

mercmobily - June 14, 2009 - 16:15

Hi,

Please be clearer... what's it doing now, and what should it be doing instead?
I am a bit confused :D

Merc.

#4

bensemmel - June 14, 2009 - 20:56

Hi Merc,

Nothing to be confused about... I hopefully can give you a more concrete scenario:

- User 1 and user 2 have a two-way relationship
- User 5, user 6 and user 7 have a two-way relationship with user 1 and user 2
- User 1 watches the profile of user 2
- Mutual friends of user 1 and user 2 are shown in the block
- The results of the block are: user 1, user 2, user 5, user 6 and user 7

As user 1 is viewing the profile of user 2, I think user 1 and user 2 should not be within the results, so that the results should be only user 5, user 6 and user 7 (This was as well the behaviour before the changes)

I hope this is a little bit clearer now.

Best regards,

Ben

#5

igorik - July 1, 2009 - 06:26

subscribe, it is really weird to have logged user and profile user in this list.

 
 

Drupal is a registered trademark of Dries Buytaert.