This is a usability problem reported by my client. When the credit card start date field is enabled, it defaults to January 1999. However, not all cards have a start date, and the checkout page itself even says "if present" next to the field. This can confuse customers as they cannot select a blank value here; some customers have called the store at this point as they are led to believe they must select a value here.

The attached patch fixes this by adding a blank row to the top of both the month and year start date dropdowns, and updates the start date validation function to succeed if both values are blank.

CommentFileSizeAuthor
uc_credit-empty-start-date.patch4.57 KBlongwave

Comments

rszrama’s picture

Issue tags: +Usability, +ubercamp sprint

Tagging.

cedarm’s picture

Status: Needs review » Reviewed & tested by the community

Tested. Works.

The only think I would change is the return value comment:
TRUE for cards whose start date is blank (both month and year) or in the past, FALSE otherwise.

Island Usurper’s picture

Status: Reviewed & tested by the community » Fixed

Good deal. Committed with Cedar's suggestion about the comment.

cnolle’s picture

This patch also works in Ubercart for D5, though by manually applying it.

Good work. Saved my day.

- Christian

Island Usurper’s picture

Version: 6.x-2.x-dev » 5.x-1.7

OK, cool. Committed to 5.x-1.x as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

greg.harvey’s picture

Is there a patch for 5.x-1.x or will the D6 patch apply?

greg.harvey’s picture

Never mind, I just tried it - for the reference of others, the D6 patch applies to UC 5.x-1.x too.