PATCH - Check for email address
_natron - June 11, 2009 - 22:00
| Project: | Invisimail |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
This patch solves the problem of invisimail displaying a mail icon when an email address was not present.
| Attachment | Size |
|---|---|
| invisimail_checkForString.patch | 399 bytes |
#1
As I look at this further, the mail icon is coming from extlink (extlink.css).
#2
After talking with Crell, I've reworked this patch slightly. Thx Crell! The problem was that if the email field was empty, I would still get ouput.
#3
Per coding standards, never ever omit the { } for an if statement. The if statement could also use a one line comment to explain why we're checking for that.
#4
This patch, revised, checks to see if an email address exists. If not, return.
#5
tab removed.
#6
pardon -- A better comment.
#7
#8
The last patch was missing a comment, so I added one and committed it.
#9
Automatically closed -- issue fixed for 2 weeks with no activity.