I get following error:
Fatal error: Call to undefined function signup_send_broadcast() in ***/sites/all/modules/signup_status/signup_status.module on line 324

Running on shared hosting
Drupal 6.12
PHP 5.2.9 (cgi-fcgi)

CommentFileSizeAuthor
#3 489270-3.signup_status_include_broadcast.patch681 bytesdww

Comments

dww’s picture

Project: Signup » Signup Status
Version: 6.x-1.0-rc3 » 6.x-1.x-dev
Component: Email » Code

That's a signup_status bug, then... It's using a function that's not included by default without loading the proper .inc file.

scubasmurf’s picture

+1

dww’s picture

Assigned: Unassigned » dww
Status: Active » Needs review
StatusFileSize
new681 bytes

I can't reproduce this locally, but the attached patch should solve it. Can someone experiencing this bug please confirm that this patch makes your problem go away? It's against the latest signup_status.module in HEAD, though it will hopefully apply cleanly to an older copy...

scubasmurf’s picture

Tested, sorry no luck fixing the problem (for me anyway). I uninstalled Signup Status and the broadcast works fine now.

dww’s picture

@scubasmurf, What's the top of your copy of signup_status.module look like? E.g.:

// $Id: signup_status.module,v 1.19 2009/08/17 22:15:40 dww Exp $

What exact version of signup are you using? Tops of both signup.module and includes/broadcast.inc would be helpful, e.g.:

// $Id: signup.module,v 1.205.2.29 2009/08/17 22:14:08 dww Exp $
// $Id: broadcast.inc,v 1.1.2.3 2009/08/14 23:26:10 dww Exp $
scubasmurf’s picture

// $Id: signup_status.module,v 1.19 2009/08/17 22:15:40 dww Exp $
// $Id: signup.module,v 1.205.2.6 2008/12/20 06:31:27 dww Exp $
// $Id: broadcast.inc,v 1.1.2.1 2008/12/20 04:28:56 dww Exp $

Error message now reads:
Fatal error: Call to undefined function signup_send_broadcast() in /modules/signup_status/signup_status.module on line 328

dww’s picture

@scubasmurf: with or without my patch from #3 applied?

scubasmurf’s picture

With your patch applied.

dww’s picture

@scubasmurf: I don't believe you. ;) If you have singup_status.module version // $Id: signup_status.module,v 1.19 2009/08/17 22:15:40 dww Exp $ and apply my patch, line 328 becomes:

  module_load_include('inc', 'signup', 'includes/broadcast');

So, either you're patching the wrong copy of signup_status or something equivalent. It's simply impossible to get the error you're seeing based on the information you've told me.

scubasmurf’s picture

I overly summarised post #8. I hadn't applied your patch when I wrote post #6, but I had by the time I wrote post #8. With the latest version of Signup Status and your patch the error shifted to line 329 if I recall correctly.

Sorry for causing confusion. My bad.

dww’s picture

I still don't see how it's possible. We *just* loaded the include file. How can this still be an undefined function?

On a whim: can you try upgrading to the latest (secure) version of D6 core: 6.13? Maybe that somehow effects this...

Otherwise, can you provide more info about your site configuration? What kind of caching is enabled? What user are you trying this as? Etc...

scubasmurf’s picture

Updated to latest dev version of Signup and Signup Status, didn't apply the patch. Seams to be working just fine.

Thank you for your help.

dww’s picture

Status: Needs review » Fixed

*sigh*

Anyway, I committed my patch to HEAD. It can't really hurt, and it might actually defend us from something crazy in the future.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.