#361277: Remove the 'post settings' admin screen and relocate contents dispersed the settings found in "Post settings" (admin/content/node-settings) to other forms and moved admin/content/node-settings/rebuild to admin/reports/status/rebuild. Yet, there remains residual references to admin/content/node-settings and admin/content/node-settings/rebuild that need to be removed or changed.

Also, node_configure() should be removed since it builds the now-defunct "Post settings" form, as well as its submit callback function, node_configure_access_submit().

Comments

JamesAn’s picture

Status: Active » Needs review
StatusFileSize
new7.61 KB

Ok, of the 3 settings in "Post settings" form, two were moved to the "Content type" config forms and one was moved to the "Site information" form.

This patch modifies the 4 references to admin/content/node-settings and admin/content/node-settings/rebuild in node_help(). It also removes node_configure and node_configure_access_submit, which were orphaned by #361277: Remove the 'post settings' admin screen and relocate contents, and changes the cancel path in the node access permissions rebuild confirm form from admin/content/node-settings, which no longer exists, to admin/reports/status.

Status: Needs review » Needs work

The last submitted patch failed testing.

jody lynn’s picture

Status: Needs work » Reviewed & tested by the community
StatusFileSize
new7.61 KB

Patch looks great to me. I was just wasting time working on that node_configure function for another issue when I realized nothing even calls it anymore...

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

jody lynn’s picture

Status: Needs work » Reviewed & tested by the community
StatusFileSize
new3.48 KB

It looks like half of this already went in. The remaining bits are here.

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.