Removing references to admin/content/node-settings

JamesAn - June 12, 2009 - 03:05
Project:Drupal
Version:7.x-dev
Component:node.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

#361277: Remove the 'post settings' admin screen and relocate contents dispersed the settings found in "Post settings" (admin/content/node-settings) to other forms and moved admin/content/node-settings/rebuild to admin/reports/status/rebuild. Yet, there remains residual references to admin/content/node-settings and admin/content/node-settings/rebuild that need to be removed or changed.

Also, node_configure() should be removed since it builds the now-defunct "Post settings" form, as well as its submit callback function, node_configure_access_submit().

#1

JamesAn - June 12, 2009 - 03:21
Status:active» needs review

Ok, of the 3 settings in "Post settings" form, two were moved to the "Content type" config forms and one was moved to the "Site information" form.

This patch modifies the 4 references to admin/content/node-settings and admin/content/node-settings/rebuild in node_help(). It also removes node_configure and node_configure_access_submit, which were orphaned by #361277: Remove the 'post settings' admin screen and relocate contents, and changes the cancel path in the node access permissions rebuild confirm form from admin/content/node-settings, which no longer exists, to admin/reports/status.

AttachmentSizeStatusTest resultOperations
489402-1.patch7.61 KBIdleFailed: Failed to install HEAD.View details | Re-test

#2

System Message - June 24, 2009 - 01:20
Status:needs review» needs work

The last submitted patch failed testing.

#3

Jody Lynn - July 6, 2009 - 00:45
Status:needs work» reviewed & tested by the community

Patch looks great to me. I was just wasting time working on that node_configure function for another issue when I realized nothing even calls it anymore...

AttachmentSizeStatusTest resultOperations
489402-1.patch7.61 KBIdleFailed: Failed to apply patch.View details | Re-test

#4

System Message - July 6, 2009 - 00:55
Status:reviewed & tested by the community» needs work

The last submitted patch failed testing.

#5

Jody Lynn - July 6, 2009 - 01:29
Status:needs work» reviewed & tested by the community

It looks like half of this already went in. The remaining bits are here.

AttachmentSizeStatusTest resultOperations
node-configure.patch3.48 KBIdlePassed: 11563 passes, 0 fails, 0 exceptionsView details | Re-test

#6

Dries - July 6, 2009 - 13:53
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks!

#7

System Message - July 20, 2009 - 14:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.