Breaks popups api
frankcarey - June 12, 2009 - 04:10
| Project: | Get Satisfaction |
| Version: | 6.x-1.1 |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | flevour |
| Status: | closed |
Description
If the popups api module is being used, and a popup link points to a location that has a feedback tab enabled (say the /user login page). Then clicking on the link causes a whitescreen with a 'FEEDBACK' link to appear.
A workaround is to disable feedback button on any pages that might be inside a popup. An ugly fix for now. Maybe there is a better way that they wouldn't conflict?
#1
Hi Frank,
have you got any live or public dev site I can access to check the thing?
Thank you very much,
Francesco
#2
no public dev right now, if you are willing to test it, I can setup a quick public drupal install with both modules.
#3
I would be very thankful if you could provide either precise steps to reproduce bug, a vanilla drupal zip configured to reproduce error or a public running instance of it, or a combination of the 3. I am a bit busy but I am willing to fix this issue before the next release.
Francesco
#4
OK, here is the test site. I tried it with popups 1.3 and it seems to work OK, but in 2.0-alpha5 it breaks popups. I have 2.0-alpha5 installed here, and GS 1.1, with drupal 6.12.
To install setup a db (I used "test"), and then import the sql in /sites/default/test.sql, then run the drupal install with your db info. Login: test, pw: test.
I enabled the popups test page module, which has a nice cross section of different popup links to try out, you can access it at /popups/test
Thanks for taking a look at it.
Cheers
Frank
#5
note: change "mysqli" to "mysql" in the settings.php file, so the install script will install correctly, sorry about that.
#6
Hi Frank,
thanks for providing the setup for reproducing the bug, it's proving to be very helpful, as I could quickly get to see the error. I'll try to fix the error asap.
Thanks again for your time and sorry for not being able to get back to you sooner,
Francesco
#7
Fixed in HEAD, should be available as a download in less than 12 hours.
I'll wait to release a 1.2 to see if any other issue comes up.
Thanks again for your interest, hope all works out well. Re-open this issue as necessary in case something doesn't work as expected.
Francesco
#8
what was the issue?
#9
Automatically closed -- issue fixed for 2 weeks with no activity.