A setting or option somewhere to not count views/clicks for the site admin and/or the ad owner would be nice. If you are selling impressions by the CPM, it doesn't seem fair to run up the count if the admin is working on the site and testing a lot, or if the ad owner is checking in to look at stats, etc.

Anyone given this any thought on how as to deal with it? (I've already put code in my templates to not display ads on admin screens, and to not display the text ad block on admin/* pages.)

By the way, I just installed this thing earlier today, and I am very, very impressed. Installed with no problems, lots of great features, and configuration/setup was a snap. Very nice work. Tip of the hat to the author(s) and maintainer(s). Now let's see if I sell any ads. Heh.

CommentFileSizeAuthor
#3 banner.module.permission.patch1.15 KBdan_aka_jack

Comments

dan_aka_jack’s picture

dan_aka_jack commented
Version: 4.6.x-1.x-dev » master

I agree with all that has been said above: this module is excellent and it would be a great addition if it could filter out admins from the stats.

(I've changed the "version" from 4.6.0 to CVS... I belive all feature requests go into "CVS")

wulff’s picture

wulff commented

I've added this functionality to cvs.

Currently, view increase blocking only works when using the db cache. Please let me know if you have an idea on how to block this when using the file cache.

dan_aka_jack’s picture

dan_aka_jack commented
StatusFileSize
new banner.module.permission.patch1.15 KB

Wow! We were both working on a patch at the same time!

Just so we can compare notes, I've attached my patch. Mine works a little differently - it creates a new permission called "do not count banners". Any users who have this "permission" will have their clicks ignored.

If you apply my Turn off JavaScript when it's not needed patch then you can stop the banner.module from counting page views by changing this:

      $struct[1][$tid][$banner_id]->views++;
      $struct[1][$tid][$banner_id]->total_views++;
      $struct[1][$tid][$banner_id]->day_views++;
      $struct[1][$tid][$banner_id]->week_views++;

to this:

	if (!user_access('do not count banners')) { // If statement added by Jack
      $struct[1][$tid][$banner_id]->views++;
      $struct[1][$tid][$banner_id]->total_views++;
      $struct[1][$tid][$banner_id]->day_views++;
      $struct[1][$tid][$banner_id]->week_views++;
	}

Thanks,
Jack

dan_aka_jack’s picture

dan_aka_jack commented

I've just added a new version of my "Turn off javascript when it's not needed" patch. If you apply my new "Turn off javascript when it's not needed" patch then you can make use of the "do not count banners" permission by changing this line:

  if ($uid != 1 && $uid != $banner->uid) {

to this:

  if ($uid != 1 && $uid != $banner->uid && !user_access('do not count banners')) {
DeVill-1’s picture

DeVill-1 commented

dan_aka_jack,
do I need to have the "Turn off javascript when it's not needed" patch in order to use your permissions patch?

dan_aka_jack’s picture

dan_aka_jack commented

Hi,

do I need to have the "Turn off javascript when it's not needed" patch in order to use your permissions patch?

Yes

wulff’s picture

wulff commented

In my latest banners-as-nodes version click are _not_ counted for the site admin and the banner owner.

Would you rather that this was split into a permission so click can be ignored by roles?

wulff’s picture

wulff commented
Status: Active » Closed (fixed)

Banner views/clicks are now ignored for the banner owner and admin.