I needed this module for drupal 5 but found out that the "only allow group members" feature didn't work.

this patch fixes this feature. the patch is based on the last dev release

it also fixes a bug in the install file

CommentFileSizeAuthor
og_contact.patch3.9 KBJohnny vd Laar

Comments

gnat’s picture

gnat commented
Assigned: Unassigned » gnat

Good catch. Thanks for the patch!

I'll check the D6 version to see if it also has the same issues - I'm pretty sure it does looking at that patch.

Anyway, I'll patch and test later today. Thanks again.

dman’s picture

dman commented

This is still a problem in the current release.

Also there is something queer where :

og_contact_check_group_member($uid, $uid)

should be 

og_contact_check_group_member($uid, $gid)

I've inherited an out-of-date already-hacked version, so I don't have a clean patch. I'd consider supplying one if the module was up with code-standards, but there's too many diffs there right now for me to provide a clean fix...

gnat’s picture

gnat commented
Status: Needs review » Closed (won't fix)

I'm working on D7 code, and final releases for D6. Closing old D5 issues.