Fixing the "private" feature
Johnny vd Laar - June 12, 2009 - 09:31
| Project: | OG Contact |
| Version: | 5.x-4.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | gnat |
| Status: | needs review |
Jump to:
Description
I needed this module for drupal 5 but found out that the "only allow group members" feature didn't work.
this patch fixes this feature. the patch is based on the last dev release
it also fixes a bug in the install file
| Attachment | Size |
|---|---|
| og_contact.patch | 3.9 KB |
#1
Good catch. Thanks for the patch!
I'll check the D6 version to see if it also has the same issues - I'm pretty sure it does looking at that patch.
Anyway, I'll patch and test later today. Thanks again.
#2
This is still a problem in the current release.
Also there is something queer where :
og_contact_check_group_member($uid, $uid)should be
og_contact_check_group_member($uid, $gid)I've inherited an out-of-date already-hacked version, so I don't have a clean patch. I'd consider supplying one if the module was up with code-standards, but there's too many diffs there right now for me to provide a clean fix...