Breaks the block admin page when separate admin theme is used [#489964]

If a separate admin theme is in use when this module is enabled, the block admin theme page is broken and will only display for the admin theme itself; selecting another theme does not work as expected and changing block order on the non-admin theme becomes impossible. Disabling this module fixes the problem.

This is because a theme function is called during hook_init; see http://drupal.org/node/219910 for more information. This same problem was found in SimpleMenu, see http://drupal.org/node/336119 for details.

Comment	File	Size	Author
#8	special_menu_items-broken_block_config-489964-8.patch	2.77 KB	mirabuck
#2	special_menu_items-489964.patch	2.34 KB	mmironenko

Comments

Comment #1

beckyjohnson commented 11 December 2009 at 18:37

For me, when I enabled this module, it made the admin menu disappear. I was using a custom theme plus garland for my admin theme.

Becky

Comment #2

mmironenko commented 18 December 2009 at 15:06

Status	File	Size
new	special_menu_items-489964.patch	2.34 KB

This is because on hook_theme_registry_alter the module is saving callback of current theme to single variable, without any checks for used themes in system. Actually all we need is save callback for every theme to separate variable, like this:
variable_set('oldtheme_menu_item_link_'.$theme, $theme_overwrite);

To be clear whats happens in current version:
For example we have one theme for site frontend (Garland) and another for admin (rootcandy).
Of course we want to use site in production with disabled setting "Rebuild theme registry on every page".
For example we open admin page and in this time admin theme registry cache expires, drupal call rebuild registry, module saves menu_item_link callback of admin theme to variable. Then we open frontend page and if theme registry cache not expired, then module trying to show us menu with callback from admin theme. This is right for opposite succession.

Here is the simple patch.