Watchdog calls causes syslog errors

Looking at mysql, I find the watchdog table is not handled correctly:

mysql> select message,variables from watchdog where type='jq';
+--------------------------------------------------+-----------+
| message                                          | variables |
+--------------------------------------------------+-----------+
| The <em>cycle</em> jQuery plugin is not defined. | i:3;      |
| The <em>cycle</em> jQuery plugin is not defined. | i:3;      |
...
| The <em>cycle</em> jQuery plugin is not defined. | i:3;      |
+--------------------------------------------------+-----------+
48 rows in set (0.00 sec)

The variables column should contain either N; for null, or a:[stuff] for an array.

Enabling http://drupal.org/project/jquery_plugin and deleting the rows from the watchdog prevents this error being logged.

I think the bug is actually in jQ module:

      // log & display an error, but only if we haven't already. don't want to overwhelm with a lot of identical errors per page
      $error = t('The %plugin jQuery plugin is not defined.', array('%plugin' => $plugin));
      if ($log_errors) {
        watchdog('jq', $error, WATCHDOG_ERROR);
      }

Instead of WATCHDOG_ERROR, the watchdog function is expecting a $variables array. http://api.drupal.org/api/function/watchdog/6

Here's a patch to fix the watchdog calls in jq/jq.add.inc so they're D6 style instead of D5 style.

Er, apply it the same as any other patch. See http://drupal.org/patch/apply for example

$ cd sites/all/modules
$ wget http://drupal.org/files/issues/jq_add_watchdog_apifix.patch
$ patch -p0 < jq_add_watchdog_apifix.patch
patching file jq/jq.add.inc