The formatting string for workflow-current-state-date-formatted is erroneous. It currently is 'M d, Y h:i:s', but should be either 'M d, Y H:i:s' (24h) or 'M d, Y h:i:s a' (12h).
The help string, elsewhere in the code, should also reflect that, and 'formated' should be 'formatted' in the same string.
Additionally, it shouldn't use date() at all, but rather format_date(theTime,'custom',theformatString), so that the output reflects the Drupal timezone selection for each user.
Thanks!

CommentFileSizeAuthor
#5 workflow_490940_time.patch1.48 KBhefox
#1 workflow-490940.patch921 bytesdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new workflow-490940.patch921 bytes

Easy patch

Bastlynn’s picture

Bastlynn commented

Since this request is over a year old, I'm going to assume a solution was found or you've moved on. If not, please get updated to the latest versions of all modules and make a patch for it against Drupal 7 and I'll be glad to take a look at it.

dawehner’s picture

dawehner
Primary language German
commented

Well i'm not really interested in these patches anymore, so there is no time to fix this issues.
If you want you can mark them as won't fix.

Bastlynn’s picture

Bastlynn commented

Just getting a live response at all bumps it up in my queue here, since that let's me know that at least one person interested is at least still around to benefit. So thanks :)

I'm going to leave this issue open so I can remind myself to check it with the next releases.

hefox’s picture

hefox commented
StatusFileSize
new workflow_490940_time.patch1.48 KB

Updated d6 patch for another area that uses format_date. Looks like patch should apply to d7 other than spacing/line numbers/changes in format_date.

Need it to remove an error that php 5.3 throws about selecting timezone. Too annoying!

johnv’s picture

johnv
Primary language Dutch
commented
Component: Code » Tokens
johnv’s picture

johnv
Primary language Dutch
commented
Title: time is wrong in workflow-current-state-date-formatted » time is wrong in token 'workflow-current-state-date-formatted' (D6)
Issue summary: View changes

ITMT, this is fixed in the D7 version. Reflecting this in the title. Leaving this open for other D6-users.

johnv’s picture

johnv
Primary language Dutch
commented
Status: Needs review » Closed (won't fix)

I wish there was a nicer way to clear the issue queue from 'D6-issues that are fixed in D7' then a "won't fix for D6."