When the patches at http://drupal.org/project/issues/search/drupal?text=&assigned=&submitted... are in, there are only a few missing bits and pieces to convert. There are a few things I'm not sure about, but the attached patch will convert almost all of them.

It will currently fail, because the INSERT INTO () FROM patch needs to go in first.

CommentFileSizeAuthor
#8 dbtng_convert_remaining5.patch21.83 KBberdir
#7 dbtng_convert_remaining4.patch21.83 KBberdir
#5 dbtng_convert_remaining3.patch22.3 KBberdir
#3 dbtng_convert_remaining2.patch22.3 KBberdir
dbtng_convert_remaining.patch27.2 KBberdir

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

cafuego’s picture

cafuego commented

I've addressed some of these (specifically a bunch in system.install) in #497684: system.install incorrectly assumes more sequential IDs

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new dbtng_convert_remaining2.patch22.3 KB

Re-roll, left out the user pieces in system_install(), because the sequences API patch should take care of that.

Status: Needs review » Needs work

The last submitted patch failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new dbtng_convert_remaining3.patch22.3 KB

Tiny error fixed...

damien tournoud’s picture

damien tournoud commented
Status: Needs review » Needs work

Nice job, again! A few issues:

     field_attach_insert($entity_type, $entity);
-    $count = db_result(db_query("SELECT COUNT(*) FROM {{$this->table}}"));
+    $count = db_query("SELECT COUNT(*) FROM {{$this->table}}")->fetchField();
     $this->assertEqual($count, 0, 'Missing field results in no inserts');

^ Those (there are a few of them) are dynamic queries. They *need* to be converted to db_select() ;)

+
+  // Set node type options.
+  variable_set('node_options_forum', array('status'));

^ ?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new dbtng_convert_remaining4.patch21.83 KB

Re-rolled with the things mentioned by DamZ fixed.

That variable_set() is currently in system_install(), where it imho makes no sense. It was a INSERT-query before but has been converted to variable_set() now. I removed it and leaving this for another issue, as it is not DBTNG-related anymore.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new dbtng_convert_remaining5.patch21.83 KB

There was a typo in the currently untested statistics_cron() function...

dries’s picture

dries commented
Status: Needs review » Fixed

Looked at it, and couldn't see anything wrong. Committed to CVS HEAD! Incredible job, Berdir.

moshe weitzman’s picture

moshe weitzman commented

Great stuff. Is there compatibility layer code that we can remove from DBTNG?

Crell’s picture

Crell commented

I think we still need to finish #394182: DBTNG search.module first before we're done, but possibly. I'll try to have a look later tonight and see.

Status: Fixed » Closed (fixed)
Issue tags: -DBTNG Conversion

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +DBTNG Conversion

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.