Corrected version

birwel - June 14, 2009 - 20:08
Project:Watcher
Version:6.x-1.2
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

Here is the patch.

AttachmentSize
nodeapi_delete.patch470 bytes

#1

solipsist - June 14, 2009 - 20:13
Status:patch (to be ported)» needs work

Thanks for submitting. I'll fix this in the next release.

If you could rewrite the patch in a way that separates the DB query from the hook implementation, I could use it as it is. Look at how Watcher is written for some examples. Note the include file with the DB functions.

Also, please do not mark your own patches as "to be ported". A patch should be reviewed by at least one other person before it's considered ready for porting or commit.

#2

birwel - June 19, 2009 - 16:33
Title:watched nodes are not cleared when a node is deleted» Corrected version
Status:needs work» needs review

Thanks for your advising. Here it is the requested version.

AttachmentSize
nodeapi_delete_ok.patch 991 bytes

#3

solipsist - July 5, 2009 - 20:22
Status:needs review» reviewed & tested by the community

Cheers! It's queued for committing!

#4

solipsist - July 10, 2009 - 15:59
Status:reviewed & tested by the community» closed

Committed.

 
 

Drupal is a registered trademark of Dries Buytaert.