Download & Extend
Watcher » Issues

Corrected version

Posted by birwel on June 14, 2009 at 8:08pm
Project:Watcher
Version:6.x-1.2
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Here is the patch.

AttachmentSize
nodeapi_delete.patch470 bytes
Login or register to post comments

Comments

#1

Posted by solipsist on June 14, 2009 at 8:13pm
Status:patch (to be ported)» needs work

Thanks for submitting. I'll fix this in the next release.

If you could rewrite the patch in a way that separates the DB query from the hook implementation, I could use it as it is. Look at how Watcher is written for some examples. Note the include file with the DB functions.

Also, please do not mark your own patches as "to be ported". A patch should be reviewed by at least one other person before it's considered ready for porting or commit.

#2

Posted by birwel on June 19, 2009 at 4:33pm
Title:watched nodes are not cleared when a node is deleted» Corrected version
Status:needs work» needs review

Thanks for your advising. Here it is the requested version.

AttachmentSize
nodeapi_delete_ok.patch 991 bytes

#3

Posted by solipsist on July 5, 2009 at 8:22pm
Status:needs review» reviewed & tested by the community

Cheers! It's queued for committing!

#4

Posted by solipsist on July 10, 2009 at 3:59pm
Status:reviewed & tested by the community» closed (fixed)

Committed.

nobody click here