- $readmore doesn't exist anymore, but is still documented in node.tpl.php
- some bits of code here and there still refer to $node->teaser, $node->body (old form), $node->readmore

CommentFileSizeAuthor
#4 491654_cleanup_body01.patch1.96 KBscor

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
scor’s picture

scor commented

Does the <span class="no-js"> bit still make sense here now the teaser splitter is gone?

./modules/node/node.pages.inc:381:    drupal_set_message(t('The trimmed version of your post shows what your post looks like when promoted to the main page or when exported for syndication.<span class="no-js"> You can insert the delimiter "&lt;!--break--&gt;" (without the quotes) to fine-tune where your post gets split.</span>'));
yched’s picture

yched commented

Good catch. Actually, that whole message should now go away, and the heading should be renamed 'Preview teaser version'.

scor’s picture

scor commented
StatusFileSize
new 491654_cleanup_body01.patch1.96 KB

patch removes $readmore documentation in node.tpl.php and tweak the message in node preview mode.

gopherspidey’s picture

gopherspidey commented
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Needs review

Bot?

cosmicdreams’s picture

cosmicdreams commented

#4: 491654_cleanup_body01.patch queued for re-testing.

eustace’s picture

eustace commented

Successfully applied patch 491654_cleanup_body01.patch with no errors.

Opened files node.pages.inc and node.tpl.php after patching and verified files properly reflect changes outlined by #2, #3, and #4.

Good Patch!

eustace’s picture

eustace commented

Awaiting results from #7 before rtbc.

scor’s picture

scor commented

#4: 491654_cleanup_body01.patch queued for re-testing.

gopherspidey’s picture

gopherspidey commented

#4: 491654_cleanup_body01.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 491654_cleanup_body01.patch, failed testing.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.