Admin Theme takes over Block Configuration

same here, this is an awesome theme!

But it seems it's taking over the blocks admin, it needs to use the frontend theme for that page.

DT

OK, I found the cause of this bug was in admin.module

admin_init, line 24

was using $item['page_callback'] which was not in scope, to test if on the blocks page.

I changed to a strpos check on $_GET['q']

patch attached.

tested and working.

keep up the good work!

DT

I found an issue where the slate theme template.php needed including for block config pages, therefore, I've refined the check to use the admin theme only if not on the _main_ admin blocks page, sub pages are ok.

patch attached.

DT

Thanks, this worked like a charm.

Thanks for the patch david -- will commit tonight.

Kinda new to Drupal and all this backend stuff.... but this module made it fun and easy to navigate through..... but spent an entire day wondering why my all the regions just stopped appearing.. i had like 20 different regions in my theme reduced to 3 main core regions. found out that is was this module and my heart broke to think i had to get rid of it.

it works very nice now.. thanks yhaun for this very helpful module and thanks david for the patch

Thanks everyone. Committed: http://drupal.org/cvs?commit=226946

Expect an alpha6 release soon.

subscribe

subscribe

Tested (using Zen), and confirmed Fixed. Thanks.

Is it just me or does this only fix viewing blocks on the current default theme. For me it seems to still have an issue with any theme that is not the default.

could also be just sub themes. as that is how my websites are setup.

This module is wicked and makes admin so easy to manuever. Thanks

Doesn't work for me either on Block admin using a normal or sub theme unless I go into configure blocks of another enabled theme other than the theme I'm using as default at the time.

Simply put no matter what my default them is it doesn't work on the admin blocks page. Everything else seems to show perfectly.

Moved to active.

Forgot to change the version # to beta1 in this post

This is verified.... it is working to properly give me block management for the default theme, but for any additional themes that are enabled, but not default, the admin theme still takes over, so I can't configure the block positioning for alternate themes.

I don't know how many verifications you need...but anyway, this is still happening on non-default themes.

Thanks for the reports, will take a look at this sometime soon.

I think I fixed it - here's my changes to the initializing slate theme code:

  else if (arg(0) == 'admin' && variable_get('admin_theme', 'slate') == 'slate') {
  	if((strpos($_GET['q'], 'admin/build/block/configure') === 0) || (strpos($_GET['q'], 'admin/build/block/delete') === 0)) {
    _admin_init_theme();
	}
	else if(strpos($_GET['q'], 'admin/build/block') !== 0) {
	_admin_init_theme();
	}
  }

If anyone could put this in a patch, that would be great. Sorry I don't have the time at the moment.

Crossposted, sorry.

This is the patch of EvanDonovan work. Works great on the two sites i tested it on. Though i haven't done extensive testing through use.

The theme did not apply when editing a block on the admin/build/block/add page (for me at least). I modified EvanDonovan's work. Here is the new patch.

@jackinloadup:

Thanks so much! I was at work, so I didn't have time to code a proper patch. Thanks for adding in the /add patch. I had forgotten about that one.

These patches made no difference to the admin/build/block as far as I can see. Could you update the current version to include this or an updated version of the admin.module file so I can test it again please? I had to do the patch by hand and not sure if I did it right. I really hate Cpanel hosting :(

Thanks everyone. Committed with small change for readability: http://drupal.org/cvs?commit=234968

Please continue posting if you continue having trouble with this issue.

If I configure a block and save then I am directed to page showing slate's (the admin theme) blocks and not my themes anymore. I have to go into appearance and save before my theme's blocks appear again.

Posting cus I've just installed beta 2 and still having the same prob.

I determined that this is still an issue in the special case of when you are trying to administer blocks for the Slate theme. Here's the modified code:

  // Initialize the slate theme. Bypass the theme system entirely so we can load our own theme into place.
  if (variable_get('node_admin_theme', 0) && (strpos($_GET['q'], 'node/add') === 0 || strpos($_GET['q'], 'admin/content/add') === 0 || (arg(0) == 'node' && arg(2) == 'edit'))) {
    _admin_init_theme();
  }
  else if (arg(0) == 'admin' && variable_get('admin_theme', 'slate') == 'slate') {
    if (strpos($_GET['q'], 'admin/build/block') === 0) {
      if (in_array(arg(3), array('configure', 'delete', 'add'), TRUE)) {
        _admin_init_theme();
      }
      // begin modification - for administering Slate theme's blocks
	  elseif(arg(3) == 'list' && arg(4) == 'slate') {
	    _admin_init_theme();
      }
     // end modification 
    }
    else {
      _admin_init_theme();
    }
  }
  else if (function_exists('admin_theme_init') && $GLOBALS['custom_theme'] == 'slate') {
    _admin_init_theme();
  }
}

This is simply a patch for @EvanDonovan code. I have not done any testing.

I still have this issue with beta3 and i can't apply the last patch to beta3, outdated.
I applied #30 and my problem has been fixed
here is the re-roll of patch #32 for beta3, please apply

This does work for me to a point, but one important block among some other blocks are not showing up as options. The main one for me is the Language block. I need this to be able to show up in the Slate theme.

Anyone have a clue on this? If not, then I will have my developer dive into it.

Thanks for all the great patch work!

Regards

Dokuro: the Slate theme doesn't have a normal left sidebar, I believe. If you want the Language block, I believe you'll have to put it in the footer.

(Sorry for the semi-off-topic post. I'll test #32 soon, as I finally upgrade this module.)

@EvanDonovan

I would be fine with that. The problem is, the block option does not show up.

Thanks for the reply.

Dokuro: If you mean that the Language block is not showing up in the blocks list, can you open a new issue for that? If it's not Admin module-related, we can move it to the module actually causing the problem.

If you mean that the blocks page is not showing for the Admin theme, can you test the latest version of the patch, because it should fix that.

I noticed this thread is from 2009, however I suddenly have this issue as well. On a fresh install it suddenly appeared. Before today it has always worked well.

I have admin 2.0 beta 3 installed with Rubik present. I tried disabling Rubik but to no avail.

Any help available on this?

I'm having this issue using Rootcandy as admin theme. Could this be something not-Admin related? If not, apologies for the thread pollution.

Tested with Garland as well, same issue. Using core 6.17.

Ok, found it: in my case, it had to do with a drupal_add_feed() that was being called in hook_init() without an if-check around it.

Appearantly, weirdness in hook_init() causes this issue to come up, see:

http://drupal.org/node/219910
http://drupal.org/node/374501