I have a multilingual site, which has French as the default language. After installing this module, I noticed that my primary links were no longer visible on the English home page. The attached patch fixes the problem for me, it ensures that menu functions don't get called in menu_breadcrumb_init() if the current page is the front page. This patch has the added benefit of ensuring that the Home link on the front page always points to the front page, which would fix issues like this #278148: menu breadcrumb leads to wrong "home" breacrumb on startpage.

CommentFileSizeAuthor
#6 menu_breadcrumb-HEAD_front_page2.patch1.41 KBdboulet
#2 menu_breadcrumb-HEAD_front_page.patch1.37 KBdboulet
menu_breadcrumb_HEAD_front_page.patch1.34 KBdboulet

Comments

niff’s picture

niff commented

I had a similar problem with the primary menu, but on a Swedish site. Clicking any home link (link or logo) with the Swedish language active made the primary menu change language to English, but with the rest of the site in Swedish. This patch fixed that problem.

dboulet’s picture

dboulet commented
Title: Using menu functions in hook_init() confuses menu system » Skip retrieval of menu path on front page
StatusFileSize
new menu_breadcrumb-HEAD_front_page.patch1.37 KB

Improved patch, rolled against latest HEAD.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented

Looks like this patch will need re-rolling against #595282: Menu weights (unless that fix fixes this one).

dboulet’s picture

dboulet commented

If #595282: Menu weights gets committed, I can re-roll the last patch, but until then it still applies to the latest development snapshot, and is still valid. Since that issue is still under heavy development, I'll assume that there is still a possibility that this patch gets committed first.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented

You're right. I've been cleaning up a bunch of older issues today, and didn't spot that your patch was submitted quite recently. Sorry for missing that.

dboulet’s picture

dboulet commented
StatusFileSize
new menu_breadcrumb-HEAD_front_page2.patch1.41 KB

New patch for review.

dboulet’s picture

dboulet commented

@xurizaemon Any chance of getting this reviewed? Patch still applies cleanly.

Ryan Palmer’s picture

Ryan Palmer commented
Status: Needs review » Reviewed & tested by the community

Patch works great for me. Thanks.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Fixed » Reviewed & tested by the community
xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Reviewed & tested by the community » Fixed

Thanks - committed.

Status: Reviewed & tested by the community » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.