Attached is a port of the ecommerce.mysql file for PostgreSQL.

CommentFileSizeAuthor
#8 ecommerce_2.pgsql7.58 KBdane_hansen
#1 ecommerce_1.pgsql7.6 KBSteve Simms
ecommerce_0.pgsql7.62 KBSteve Simms

Comments

Steve Simms’s picture

Steve Simms commented
StatusFileSize
new ecommerce_1.pgsql7.6 KB

New schema. ec_transaction's txnid needs to be a SERIAL.

gordon’s picture

gordon commented

Thanks very much for this. I have updated ecommerce to use the new install system, so can you please port this schema to the *.install files.

I don't think it is needed but the previous updates, it may be nice to convert these to.

Thanks for this.
Gordon.

gordon’s picture

gordon commented
Status: Needs review » Needs work
Steve Simms’s picture

Steve Simms commented
Assigned: Steve Simms » Unassigned

Sorry, updating all of those files is more work than I want to take on, especially for an API that seems to be getting thrown in at the last minute (i.e. after four 4.7 beta releases).

moshe weitzman’s picture

moshe weitzman commented

um, you are confusing contributed module release schedule with core release schedule. contributed modules get updated when the volunteer maintainers have time. core is a bit more organized and attempts to at least communicate release status. a contributed module cannot release "at the last minute" by definition.

and, your comment is a bit insulting to everyone who is working hard to improve *free software*. you might not have meant it that way, but it is.

Steve Simms’s picture

Steve Simms commented

Hi Moshe,

Sorry, it was not my intent to insult by any means. I'm clearly interested in helping improve Drupal, as I hope my participation, patches, and testing over the past few weeks demonstrates. That part of my comment was not directed at the E-Commerce module's code, either -- apparently, I should have stated that explicitly.

"The new install system" is what seems to have appeared in 4.7 after four beta releases of the code, and it was that to which I'm referring. It may very well be a great system, but I don't know where to find out about it (it isn't mentioned at all that I can find in the various contributors nodes in the handbook). So, I wonder if it wouldn't have been better or more disciplined to leave out of the 4.7 release, but since I haven't found any references to it other than a node that states that it's in core already, I don't know where to give that feedback, or even if feedback (especially an encouragement to wait) would be appreciated at this point.

I'm still quite new to the Drupal contribution process, which is quite unlike other open source projects with which I've been involved, so I would really appreciate any input you can give on where I can go to find out more information on changes to APIs, release status info, and contributing effectively. Until then, I'll try to keep up and contribute as best I know how.

In any case, my goal with this message was merely to say that I am not willing to take the time right now to change what was a very simple SQL file conversion into a much more complicated multi-file patch, and give someone else the opportunity to do so. I didn't want to just abandon the issue without saying so, and thereby cause confusion or delays. The changes themselves will probably be fairly simple copy-and-pastes as long as you don't get into updates, but it's going to involve touching a number of files and will result in a rather long patch.

Hoping this helps clear things up,
Steve

gordon’s picture

gordon commented

I am sorry that you cannot do these changes.

The actual install api has been in core since before the betas, it is just that now the contrib developers have started using this to make installing and updating there modules much easier for users.

I do really want pgsql support in 4.7, as it would cover a need that is out there. All the hard work has been done with the *.install files, I just need the blanks filled in for pgsql.

The other thing is that the person who creates the pgsql support, I expect to take responsibility for in the future, and make sure that any major changes don't break this. I do not expect this to be a huge responsibility, but I do not want pgsql support to go away because it is not being supported.

Thanks for your help so far.\
Gordon.

dane_hansen’s picture

dane_hansen commented
Version: master » 4.6.x-1.x-dev
Category: feature » bug
StatusFileSize
new ecommerce_2.pgsql7.58 KB

Hi I am new to Drupal, I am looking for a postgres ecommerce solution. Hence I am here.
I have got Drupal-4.6.6 running with ecommerce-4.6.0 and ecommerce_1.pgsql from above.
After briefly playing with the settings I have noticed that the Home » administer » store add tax option fails.
My postgres log has

LOG: statement: SELECT nextval('ec_tax_taxid_seq')
ERROR: relation "ec_tax_taxid_seq" does not exist
LOG: statement: INSERT INTO watchdog (uid, type, message, severity, link, location, hostname, timestamp) VALUES (1, 'php', 'pg_query() [function.pg-query]: Query failed: ERROR: relation "ec_tax_taxid_seq" does not exist in /Library/WebServer/Documents/drupal-4.6.6/includes/database.pgsql.inc on line 45.', 2, '', '/drupal-4.6.6/?q=admin/store/tax/add', '10.0.2.101', 1143851129)
LOG: statement: INSERT INTO watchdog (uid, type, message, severity, link, location, hostname, timestamp) VALUES (1, 'php', '
query: SELECT nextval('ec_tax_taxid_seq') in /Library/WebServer/Documents/drupal-4.6.6/includes/database.pgsql.inc on line 62.', 2, '', '/drupal-4.6.6/?q=admin/store/tax/add', '10.0.2.101', 1143851129)

LOG: statement: INSERT INTO ec_tax (realm_value, realm, ptype, operand, operator, taxid) VALUES('au', 'country', 'tangible', '%', '10', '')
ERROR: invalid input syntax for integer: ""

In short I belive table ec_tax column taxid should be type serial not integer
the attached file has only line 190 changed from
taxid INTEGER NOT NULL DEFAULT '0' PRIMARY KEY,
to
taxid SERIAL PRIMARY KEY,

I have done a quick search of the ecommerce code it appears the function db_next_id() is only called on tables ec_transaction and ec_tax, So providing no new code calls it on other tables it should be fine...

~d

gordon’s picture

gordon commented

This is an internal drupal function and not a E-Commerce issue, You will need to find someone who knows more about the prostgres support.

Check the maintainers file from the drupal install, He maybe able to help you.

Gordon

sime’s picture

sime
any/any
Location Melbourne
commented
Component: other » -- other --
Status: Needs work » Closed (won't fix)

We are not supporting 4.6 now. Please re-open if any problems.