Patch for a couple tests with an error
jrchamp - June 16, 2009 - 16:46
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | simpletest.module |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed |
Description
modules/php/php.test:
* incorrect array structure (fatal errors)
modules/simpletest/tests/xmlrpc.test:
* incorrectly labels an assert
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| drupal_test_fixes.patch | 1.39 KB | Idle | Failed: Failed to apply patch. | View details |
#1
How come these fatal errors were not reported?
#2
Maybe my setup is strange, but I enabled the simpletest module and tried to do a run through of all of the tests. It ran out of memory a couple times, so I attempted to continue from the last completed test.
Running the first PHP test without the array structure changes yields:
Fatal error: Unsupported operand types in modules/simpletest/drupal_web_test_case.php on line 679
Clicking continue yields the following (with no failed tests, just "The test run did not successfully finish."):
Undefined offset: 0 Notice drupal_web_test_case.php 679 DrupalWebTestCase->drupalCreateNode()
#3
It's a know problem that fatal errors in tests result in tests simply being skipped (less 'passes'), but no fail or warning.
#443154: Fatal errors in tests not reported as failures
#4
Seems we should fix the issue referenced in #3 and re-evaluate this issue at that point.
#5
@boombatower: Alright, so you plan to use the existing PHP filter fatal error as the test mechanism for the issue referenced in #3?
#6
I suppose that is right, once other is ready it will fail due to these...so we can either patch them all in one shot in other issue or patch these now as long as it doesn't fail.
Let bot review...
#7
The last submitted patch failed testing.
#8
First part was already committed.
#9
Committed. Thanks!
#10
Automatically closed -- issue fixed for 2 weeks with no activity.