Maintainer bin

+++ ./context_admin.info	2010-02-22 14:47:22.000000000 -0600
@@ -0,0 +1,6 @@
\ No newline at end of file

This should not happen

+++ ./context_admin.module	2010-03-02 00:52:16.000000000 -0600
@@ -0,0 +1,123 @@
+     	$function = $plugin['module'] .'_'. $callback .'_form_alter';
+     	$function($form, $form_state, $form_id);
+   	} ¶

Watch out! Tabs (!) and trailing white-space here! :)

+++ ./includes/context_admin.views_default.inc	2010-03-01 11:28:15.000000000 -0600
@@ -0,0 +1,328 @@
+      'views_bulk_operations_delete_node_action' => 'views_bulk_operations_delete_node_action',

Hidden dependency on VBO?

+++ ./plugins/access/term_parent.inc	2010-02-23 10:59:32.000000000 -0600
@@ -0,0 +1,92 @@
+/**
+ * Compress the node_types allowed to the minimum.
+ */
+function context_access_term_parent_access_settings_submit(&$form, &$form_state) {
+
+}

Not the only templated function? But anyway -- I'm not (yet) sure whether I understand how all these files/functions really interact with each other, and I guess what I'm still missing most is a help page or simply README.txt that explains the design goals and architecture.

+++ ./plugins/access/term_parent.inc	2010-02-23 10:59:32.000000000 -0600
--- ../blank/plugins/administrations/admin_section.inc	1969-12-31 18:00:00.000000000 -0600
+++ ./plugins/administrations/admin_section.inc	2010-02-24 11:11:18.000000000 -0600

Why is this plural? And why not just "admin" ?

+++ ./plugins/administrations/user_create_menu.inc	2010-03-06 19:27:19.000000000 -0600
@@ -0,0 +1,255 @@
+  if (!is_null($form_state['handler_id'])) {

Whenever you use is_null(), replace it with !isset()

+++ ./plugins/administrations/user_create_menu.inc	2010-03-06 19:27:19.000000000 -0600
@@ -0,0 +1,255 @@
+function context_admin_user_create_menu_render_form($form_state, $handler, $base_contexts, $args, $test = TRUE) {
+  $form = array();
+
+  // Display the registration form.
+  if ($handler->conf['context_admin_user_registration_help']) {
+    $form['user_registration_help'] = array(

Why are we duplicating all these forms? Wouldn't it make more sense to just build the original forms and afterwards process them and set #access => FALSE on stuff that's not wanted?

Powered by Dreditor.