Closed (fixed)
Project:
Drupal core
Version:
5.x-dev
Component:
Garland theme
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Jun 2009 at 00:34 UTC
Updated:
30 Sep 2009 at 04:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
threexk commentedAlso occurs in D5.
Comment #2
threexk commentedAlso occurs with IE6.
Comment #3
tic2000 commentedPatches for D7 and D6.
Can you try them out? I don't have ie7. Only 6, and it seems to fix the problem (I used D7 to test).
Comment #4
threexk commentedTested both D7 and D6 patches and they work.
Made the same modifications in D5 and it seemed to fix the problem on my sites without ill effect.
Comment #5
tic2000 commentedAn alternative solution for D7 so we don't touch other browsers.
When/if a backport will be made we can talk about what solution to use in D6.
Comment #6
threexk commentedI have tested patches -v2 and -v2-d6 in IE6, IE7, IE8, Firefox 3, and Safari 4 without problems.
Patch -v3 does not seem to work for HEAD and IE7. I favor the -v2 patch anyway, though, because it is better to use the same CSS for every browser and not have browser-specific CSS when possible. (Of course changing CSS that affects every browser gives the change a larger scope.)
Setting this back to RTBC since my opinion is that the -v2 patch is the way to go, and it works. Feel free to overrule.
Comment #7
Stefan Nagtegaal commentedWhy do you decrease the vertical padding?? It doesn't make sense that the float is fixed with that..
I do understand that the display: inline-block; could fix things up, but still I'm wondering what your reasons are to decrease the padding on the top.
Comment #8
tic2000 commentedBecause when inline-block is set tabs moves down a little. On all browsers. So I decrease the padding to move everything back.
Comment #9
tic2000 commentedSome images to prove my point. And now that I did this, I thing I should change the bottom padding too.
Comment #10
tic2000 commentedOn second thougt, I should not obses about getting the same result to pixel and just solve the bug.
Comment #11
tic2000 commentedA patch without padding change.
Comment #12
threexk commentedTested -v4 in IE6, IE7, IE8, Firefox 3, and Safari 4. The few-pixels shift of the tabs looks fine to me.
Comment #13
webchickCommitted to HEAD. Thanks!
Marking down to 6.x for consideration.
Comment #14
threexk commentedPatch in #11 is for D6 and has been tested. It causes the tabs to move by a few pixels, as with D7. In my opinion, (1) the appearance of the tabs is still fine, and (2) disappearing tabs are worse than the tabs being moved by a few pixels.
Comment #15
gábor hojtsyThanks, committed to Drupal 6. As per comments above, also applies to Drupal 5.
Comment #16
drummCommitted to 5.x.