It would be good if the site gave some basic information about the site (e.g. site name, slogan, mission and footer) back to the client when connecting. Putting this functionality in system.connect saves opening up the system.getVariable method to users as that could potentially cause security issues, but it could potentially be included elsewhere, either in another method or or in its own.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | services_add_site_information.patch | 974 bytes | geodaniel |
| services_add_site_information.patch | 987 bytes | geodaniel |
Comments
Comment #1
geodaniel commentedSorry, revised patch attached as the mail variable is potentially more sensitive.
Comment #2
marcingy commentedThis function is used to connect to the site and generate a session. This additional information is not related to a session.
Comment #3
geodaniel commentedWould you accept this if it was rerolled as a new function?
Comment #4
marcingy commentedIf it was rerolled as a new function the patch would then at least get reviewed and discussed by the services team as to whether or not the feature will be included. Marking as needs work.
Comment #5
marcingy commentedMarking as won't fix until a patch is supplied for the issue that does this as a seperate method.