Mysql 5.0.12 and up has changed the join semantics slightly. This patch fixes 2 places where the use of db_rewrite_sql is generating the errors: "Unknown column 'n.nid' in 'on clause'", when the node_privacy_byrole and image modules are active.

For more info see: http://drupal.org/node/43735#comment-92865

CommentFileSizeAuthor
taxonomy.module_16.patch1.09 KBstarbow

Comments

Tobias Maier’s picture

Tobias Maier commented

is this a issue for cvs/head too?
if so please provide a patch

dww’s picture

dww
we/he/they
commented

is this a issue for cvs/head too?

yes, although there might be a patch to db_rewrite_sql that fixes this once and for all.
it's not clear if/when that's going to get applied, however, so we'll have to follow that issue to see what we should do about this one.

thanks,
-derek

dww’s picture

dww
we/he/they
commented

FYI: the fix listed in my previous comment just got applied to HEAD, so this will no longer be an issue for 4.7 and beyond. therefore, this patch is *just* for 4.6 compatibility with MySQL 5.0.12+. i'd still vote on getting it in, just in case a 4.6.6 is released, since it'd be nice for us to support modern MySQL and the fix is small and well-understood. thanks.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Reviewed & tested by the community

in fact, setting this to RTBC...

dries’s picture

dries commented

It would be nice if one or two other people could test this patch for a while.

yktdan’s picture

yktdan commented

I am willing to test. Where are the patched modules for 4.6.5?

dries’s picture

dries commented

See the link above.

dww’s picture

dww
we/he/they
commented
Version: 4.6.5 » 4.6.6

actually, i think the better solution to this problem is to just fix db_rewrite_sql() ala #51850... but that's a bigger, potentially more scary change. however, if we did that, we wouldn't need to do this...

chx’s picture

chx commented
Status: Reviewed & tested by the community » Needs work

per dww's comment this needs work.

magico’s picture

magico commented
Version: 4.6.6 » 4.6.9
Status: Needs work » Closed (duplicate)

I'm closing this one and forward it to http://drupal.org/node/51850

Both issues talk about the same problem in two similar ways, but the other thread has more posts and, supossedly, more information.

@dww: please take a look at the other thread, to see if we can do something about it. Thank you.