Download & Extend
Provision » Issues

backup succeeds even if database connexion fails

Posted by anarcat on June 17, 2009 at 5:12pm
Project:Provision
Version:6.x-0.2
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

We seem to be lacking some error checking in the backup system, as demonstrated by #494358: import doesn't escape characters in db_url.

Login or register to post comments

Comments

#1

Posted by anarcat on June 17, 2009 at 5:16pm
Status:active» needs review

Here's a quick fix, not tested yet.

AttachmentSize
494376_backup_sql_check_hotfix.patch 4.78 KB

#2

Posted by anarcat on June 17, 2009 at 5:30pm
Status:needs review» needs work

That patch includes parts of the other fix, needs work.

#3

Posted by anarcat on June 17, 2009 at 5:45pm
Priority:critical» normal
Status:needs work» fixed

I will commit this patch, it's trivial and works well. I don't feel this warrants the critical/hotfix status anymore.

AttachmentSize
494376_backup_sql_check_hotfix.patch 1.19 KB

#4

Posted by System Message on July 1, 2009 at 5:50pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.