backup succeeds even if database connexion fails

anarcat - June 17, 2009 - 17:12
Project:Provision
Version:6.x-0.2
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

We seem to be lacking some error checking in the backup system, as demonstrated by #494358: import doesn't escape characters in db_url.

#1

anarcat - June 17, 2009 - 17:16
Status:active» needs review

Here's a quick fix, not tested yet.

AttachmentSize
494376_backup_sql_check_hotfix.patch 4.78 KB

#2

anarcat - June 17, 2009 - 17:30
Status:needs review» needs work

That patch includes parts of the other fix, needs work.

#3

anarcat - June 17, 2009 - 17:45
Priority:critical» normal
Status:needs work» fixed

I will commit this patch, it's trivial and works well. I don't feel this warrants the critical/hotfix status anymore.

AttachmentSize
494376_backup_sql_check_hotfix.patch 1.19 KB

#4

System Message - July 1, 2009 - 17:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.