backup succeeds even if database connexion fails [#494376]

We seem to be lacking some error checking in the backup system, as demonstrated by #494358: import doesn't escape characters in db_url.

Comment	File	Size	Author
#3	494376_backup_sql_check_hotfix.patch	1.19 KB	anarcat
#1	494376_backup_sql_check_hotfix.patch	4.78 KB	anarcat

Comments

anarcat commented 17 June 2009 at 17:16

Status:

Active

» Needs review

Status	File	Size
new	494376_backup_sql_check_hotfix.patch	4.78 KB

Here's a quick fix, not tested yet.

anarcat commented 17 June 2009 at 17:30

Status:

Needs review

» Needs work

That patch includes parts of the other fix, needs work.

anarcat commented 17 June 2009 at 17:45

Status	File	Size
new	494376_backup_sql_check_hotfix.patch	1.19 KB

I will commit this patch, it's trivial and works well. I don't feel this warrants the critical/hotfix status anymore.

1 July 2009 at 17:50

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

12 June 2014 at 08:41

Commit cd1558d on debian, dev-dns, dev-envobject, dev-koumbit, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, dev-newhooks, dev-nginx, dev-platform_management, dev-ports, dev-purgebackup, dev-restore, dev-services, dev-simplerinstaller, dev-site_rename, dev-ssl, dev_716166_apache_conf, dev_dns, dev_server_verify, prod-koumbit, ssl, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x authored by anarcat:
```
#494376 - proper error checking in mysql backups
```