No search performed on bad URL

silurius - June 17, 2009 - 21:28
Project:Search 404
Version:6.x-1.4
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Recently I updated a test version of my site from 6.9 to 6.12, along the way ensuring that Search 404 was preserved. For some reason when a bad URL is entered (e.g. www.example.com/does/not/exist), a search is not actually performed (the search form is still provided). On the live 6.9 version of the same site, the module behaves itself just fine. On both sites, standard searches are working fine.

I have combed through the files and modules page and cannot find any dependencies or anything else I might have missed. Short of the drupal versions (6.9 & 6.12), the two sites are (as far as I know) identical and live under the same hosting environment. Please help and thanks for the great module!

Similar issues:

#418192: Unexpected results with search404?
#489260: No results appear when search-results.tpl.php is included in the theme (modified or not)

#1

szy - June 18, 2009 - 16:31

What is this page telling you:

-> your-drupal.com/admin/settings/search

Is your site indexed completely?

Szy.

#2

silurius - June 18, 2009 - 22:53

Good question. As it turns out, my cron began acting up after upgrading to Drupal 6.12. Cron is running fine now after some trial and error today, but Search indexing seems to be stuck at 98% even after running cron repeatedly with various values set for "number of items to index" in Search Settings. No errors are generated anywhere, though, and standard searching seems to be running fine.

How definite is it that this is the issue? Any other ideas come to mind? Thanks for the quick reply, szy.

#3

dstol - June 19, 2009 - 11:07

I can confirm this issue. Fresh install d6.12 > Devel generate 500 nodes > 100% search index. 404 page just shows a search form but has not searched.

#4

silurius - June 19, 2009 - 15:55

Thanks for confirming, dstol. (Now I know this issue is probably not tied to my other issue).

#5

szy - June 19, 2009 - 19:50

Next hint:

does your user have rights to use search?

Szy.

#6

silurius - June 19, 2009 - 20:58

Yes, on my site all users (including anonymous) have "search module > search content" (but not "advanced search") checked.

#7

dstol - June 20, 2009 - 16:38

I can confirm also that all users anon included have perms for search but I was logged in as user/1 anyways.

#8

hamsterbacke82 - June 21, 2009 - 14:54

hello guys,
I have the same problem

thanks for any support in advance

#9

roboneale - June 22, 2009 - 14:59

Same problem here using freshly installed d6.12 with no contrib modules.

Thanks

#10

msbdrup - June 22, 2009 - 16:19

Also same problem using d6.12 -- 404 pages show:
The page you requested was not found.
Enter your keywords:

Search index: 99% of the site has been indexed. There are 4 items left to index.

#11

silurius - June 22, 2009 - 16:56

For what it's worth, my search index is now at 100% again and the issue remains.

#12

adan - June 23, 2009 - 10:17

Hi,

It seems to be a bug in get_keys function, it expects a request property to be set ('destination'), but it doesn't. I did a quick fix (patch attached), but it needs a more in deep revision.

AttachmentSize
get-query-keys.patch 377 bytes

#13

sonac - June 22, 2009 - 19:51

I tried adan's patch and it works! finally this module works for me as it should!

#14

szy - June 22, 2009 - 19:51

Heh, now it works for me as super user, but it doesn't for anonymous.

Szy.

#15

nickhoffman - June 23, 2009 - 19:01
Status:active» needs review

Attached is a patch that's very similar to adan's, but more concise.

I can confirm that applying either my patch or adan's solves this problem with Drupal 6.12 and Search404 6.x-1.4 .

Cheers,
Nick
SoftCom Inc
http://softcom.com

#16

nickhoffman - June 23, 2009 - 19:02

Hrm, my patch wasn't attached. It is now.

AttachmentSize
search404.fix_get_query_keys.patch 537 bytes

#17

zyxware - June 25, 2009 - 07:16

Hi All

This patch has been applied in the latest dev version commit 9 days back.

Let us know in case of issues with the latest dev

Regards
Zyxware

#18

GatorBat - June 26, 2009 - 15:28

I'm having this exact same issue with the 6.x-1.6 version of the module on Drupal 6.12. When searching for "bad urls", it only brings up the standard search form, and not the Search404 related search. Has the patch mentioned been applied in the 6.x-1.6 version, or is it only in the latest dev verison labeled 6.x-1.x-dev 2009-Jun-26?

#19

silurius - June 26, 2009 - 15:54
Version:6.x-1.4» 6.x-1.6

Just updating to reflect that this is still broken in 6.x-1.6. (Thanks for the patch and the dev update, guys.)

Editing to respond:

Has the patch mentioned been applied in the 6.x-1.6 version, or is it only in the latest dev verison labeled 6.x-1.x-dev 2009-Jun-26?

No, I don't believe the fix has actually progressed beyond dev at this point.

#20

GatorBat - June 26, 2009 - 16:02
Version:6.x-1.6» 6.x-1.4

Thanks for the heads-up, silurius. After re-reading #17, it does sound like it hasn't made it past the dev version yet. I can confirm that running Drupal 6.12 and the "current" dev release dated 2009-Jun-26 now has the search404 module working properly again. Many thanks for the assistance, and I look forward towards the next "full" release that contains this patch.

#21

zyxware - June 29, 2009 - 08:18

The latest release 6.x-1.7 has this patch applied.

Regards
Zyxware

#22

silurius - June 29, 2009 - 15:37

Thanks! Patch confirmed. 6.x-1.7 works great now. This issue is resolved, as far as I am concerned.

#23

roboneale - July 1, 2009 - 12:07

Thanks. 6.x-1.7 is working for me too.

#24

zyxware - July 6, 2009 - 14:18
Status:needs review» fixed

I am changing the status for fixed for this issue.

Regards
Zyxware

#25

System Message - July 20, 2009 - 14:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.