Install fail on PostgreSQL [#494890]

PostgreSQL uses double quotes to escape table and column names so using double quotes around strings is not a good idea. These fail on PostgreSQL

db_query('INSERT INTO {search_files_helpers} VALUES(NULL, "%s", "%s", "%s")', "PDF", "pdf", "/usr/bin/env pdftotext %file% -");
db_query('INSERT INTO {search_files_helpers} VALUES(NULL, "%s", "%s", "%s")', "Text", "txt", "/usr/bin/env cat %file%");

Should be

db_query("INSERT INTO {search_files_helpers} VALUES(NULL, '%s', '%s', '%s')", "PDF", "pdf", "/usr/bin/env pdftotext %file% -");
db_query("INSERT INTO {search_files_helpers} VALUES(NULL, '%s', '%s', '%s')", "Text", "txt", "/usr/bin/env cat %file%");

Now that search files is becoming an api, other modules are starting to use it. more the reason to have good support.

Comment	File	Size	Author
#1	494890.patch	1.98 KB	jhodgdon

Comments

Comment #1

jhodgdon

she/her

English

commented 22 June 2009 at 19:19

Status:

Active

» Needs review

Status	File	Size
new	494890.patch	1.98 KB

Here is a patch against the 6.2 branch of Search Files. I only patched the Search Files API module. I have tested that it still installs and uninstalls fine under MySQL -- hopefully someone who has PostgreSQL can test on that platform?

Comment #2

jhodgdon

she/her

English

commented 22 June 2009 at 19:20

And by the way, although the patch only affects the .install file, I did look at the .module file, and there doesn't appear to be any quote problem there.

Comment #3

josh waihi commented 25 June 2009 at 20:42

Status:

Needs review

» Reviewed & tested by the community

I like it.

Comment #4

jhodgdon

she/her

English

commented 24 July 2009 at 13:41

Is there some way we could get this fix into Search Files HEAD, and then into a Beta or RC release sometime soon? I am hoping to use Search Files API as a dependency of a new version of my Search by Page module, and it is holding me up that Search Files API cannot be installed on PostgreSQL. (see #460942: Add file indexing support.)

Thanks!