When testing ffmpeg Wrapper, I uploaded a file with several special characters.

including '[', ']', '_', and '-'

the escaped path allowed ffmpeg to believe it was looking in several directories.

Comments

arthurf’s picture

arthurf commented

Huh- the thought was escaping the file names was necessary to deal with windows. Because ffmpeg wrapper can process files that are not uploaded through drupal, it seemed like it should be responsible for sanitizing input- do you think this is not necessary? I'm a bit unclear on how it should act- thoughts are welcome!

theDroplet_Sam’s picture

theDroplet_Sam commented

Arthurf,

during the last hour or so, I've found that those characters would also affect normally uploaded files.

Oh, speaking of which, I am not on windows.

Debian Lenny Arc64., Php5, mysql 5.

BTW, thanks for the hard work of putting this module together, it was amazingly easy to configure.

I got a feeling the biggest problem was 'multiple shells' possibilities.

I'd suggest you do a check for OS, and force run ffmpeg within shell scripts. Ie, for win32/64 systems, run batch files, for *nix systems, force it on sh.....but that's just my suggestions.

arthurf’s picture

arthurf commented

so perhaps do a wrapper around the shellescape command and check for the os when it gets called?

theDroplet_Sam’s picture

theDroplet_Sam commented

yeah,

Or you can force the users to have a name scrubber installed.

I've found that it wasn't just the 'Test' area, but I've been getting similar problems with the same file in standard uploads.

arthurf’s picture

arthurf commented

Can you give me the actual command output you're getting with your text files?