When enabling the number of attempts "notice" for the module, and this option is set to 0, the message will display:

"You have used 8 out of 0 login attempts. After all 0 have been used, you will be unable to login."

In fact, not only "8 of 0" is ugly, but the sentence warning it's not true, because no action will be taken to avoid the login operation.

CommentFileSizeAuthor
#2 login_security_495226_1.patch1.25 KBilo

Comments

ilo’s picture

ilo commented

Correction: ...When enabling the number of attempts "notice" for the module ("Notify the user about the number of remaining login attempts"), and the "Maximum number of login failures before blocking a user" option is set to 0, the message will display... Sorry

ilo’s picture

ilo commented
Assigned: Unassigned » ilo
Status: Active » Needs review
StatusFileSize
new login_security_495226_1.patch1.25 KB

I've just removed the message if enabled, when the "Maximum number of login failures before blocking a user" variable is set to 0.

ilo’s picture

ilo commented
Status: Needs review » Fixed

Commited to 6.x-1.x-dev and HEAD

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

deekayen’s picture

deekayen commented
Status: Closed (fixed) » Needs review

This didn't get committed. I see it in the commit comment for only 1.14 and http://drupalcode.org/viewvc/drupal/contributions/modules/login_security... says there is no difference from the previous revision.

deekayen’s picture

deekayen commented
Status: Needs review » Closed (fixed)

nevermind, I was looking at the wrong file

  • ilo committed 9de1cb3 on 6.x-1.x, 8.x-1.x 
    Applied: [#495226] [#493164]