Hi,

The Flag 6.x (maybe 5.x too) doesn't decrease the counts on user deletion. My little patch fixes this.

CommentFileSizeAuthor
#2 flag_user_delete_counter2.patch1.04 KBquicksketch
#1 flag_user_delete_counter.patch956 bytesquicksketch
flag6_user_delete_counter.patch1.46 KBaries

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed
StatusFileSize
new flag_user_delete_counter.patch956 bytes

Thanks, the patch works great except for a small type where "$flag_data->counter--" should be "$flag_data->count--". I cleaned up the code to match the code style in the rest of Flag (SQL queries are one line, no abbreviations for variable names). I've committed the attached patch for all versions of Flag.

quicksketch’s picture

quicksketch
he/him
commented
StatusFileSize
new flag_user_delete_counter2.patch1.04 KB

Oops, and a small followup to make the query join on both content_id and content_type, otherwise we'd only be updating users OR nodes OR comments for a particular content_id. Also committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.