Activity2 Integration

Patch says it is malformed. Here is a re-roll that works.

Hi folks

I've been away for a while but recently back into this and have installed the latest dev build and applied the above patches. I can configure individual flags but they aren't getting written to the activity table but there are writes to activity_access for the flagging events.

Any quick ideas on why this could be (or have I missed something?) before I go digging deeper?

Just noticed this is a Flag issue. I am referring to Activity module (latest dev build) with flag integration patches.

Thanks

Simon H

Hi Scott

I had set both my 2 flag types already and left bookmark and comments blank. I figured this bit was ok, otherwise it wouldnt be logging in activity_access?

Any other ideas? I'll try to figure it out as soon as I get the chance. I presume the latest CVS and the above two flag patches are all I need?

Hi folks

I've done a bit of work and have discovered a few issues in acitivity module and activity patch for flag module:

1. activity_get_module_info(), line 26 needs changed to require_once $info->path .'/'. $module .'.activity.inc'; so the include path is correct, as per the location of flag.activity.inc.
2. In activty_record(): $record->uid = (!empty($context[$type]->uid)) ? $context[$type]->uid : $user->uid;
$context[$type]->uid didnt exist and $user wasnt a global.

Where the main failure is, is at activity_record_check(), or rather, flag_activity_type_check() in the flag acitivity patch:

function flag_activity_type_check($token_objects, $types) {
  return (in_array($token_objects['flag']->fid, $types));
}

$token_objects['flag'] doesn't seem to exist, and therefore, $token_objects['flag']->fid doesn't exist.

So, this is where I'm stuck. Can you suggest a suitable replacement for flag_activity_type_check() or how we get 'flag' into $token_objects if required?

Thanks

Simon

Hi again

I also noticed that when flagging, activities get logged for each flag type, regardless. And if each node has multiple locations (Location module) I end up with the flag activity logging 4 times, 2 flag types, 2 locations, 1 node. Any ideas on this one?

Thanks again

Simon

I have applied the #495524: Fix Flags Trigger implementation :-D patch as well as this patch and had a thought. I currently have a flag called 'favorite' which can apply to two different content types. Each content type appears at a different path that was created by pathauto. For example:

Content Type #1 - path is /type1/[nid]
Content Type #2 - path is /type2/[nid]

My flag action of 'favorite' can apply to BOTH content types. One of the challenges now is that the flag actions are not created as a 'trigger' of the node. So when I go to settings/activity/create and select flag, content has been flagged, I can do it but the public message now can't be linked back to the nodes because I could only provide a single path. I.E. I can only set the public message set to:

Person 1 flagged this

since the path will be correct for one node type but not the other.

One potential solution for my use case would be to move the flag action as a sub-type to the nodeapi. In that instance I would go to Create -> Node -> and one of the triggers would be "Flag". In this case I could then create a node flag trigger for each content type so I could correctly provide the two different paths.

Does that make sense?

I agree with #6 - the include path in activity seems to be incomplete. Since the new flag include is in the modulepath/flag/includes/flag.activity.inc, activity.module should do something like this starting around line 20:

      if (isset($info->api) && $info->api == 2.000) {
        // Set the defaults. Not all modules implement the full api
        if (!isset($info->path)) {
          $info->path = drupal_get_path('module', $module);
        }
        elseif (file_exists('./'. $info->path .'/'. $module .'.activity.inc')) {
          require_once './'. $info->path .'/'. $module .'.activity.inc';
        }
        elseif (file_exists('./'. $info->path .'/includes/'. $module .'.activity.inc')) {
          require_once './'. $info->path .'/includes/'. $module .'.activity.inc';
        }

Whereby the last elseif is the addition.

Even with that fix, it still doesn't work for me despite being configured under settings for the activity access control and having a created activity to record the flag type and display some output. Not sure why, but I am out of time for now.

Here's a reroll with the following nitpicks fixed:

- Fixed comments to be sentences, fixed line wrapping.
- Remove whitespace at end of lines.
- Clarified comments, fixed grammar.
- Changed the object keys to be all lower case in hook_activity_info(), since that's what activity module does. Should multiple words be separated with underscores instead of spaces?

A few questions:

    // Currently, flagging a user cannot be recorded.
    if ($flag->content_type != 'user') {
      $info->type_options[$flag->fid] = $flag->title;
    }

Why can't user flags be recorded? Does this mean flags on taxonomy terms, files, or other datatypes aren't supported either? Maybe this should be hard-coded to only support node and comment rather than excluding only user.

When completed, this patch will only be applied to the 2.x version since it makes API changes and adds new functionality.

It is not reflective of the ability to handle other Drupal objects.

Well that's good news. Is there anything else that needs consideration here? I think things look good otherwise.

Hi Scott and quicksketch, thanks for your work on this. I've tried installing the latest (sept. 23) activity 2.x-dev module and the flag 2.x-dev, applying the patch in #13 and I get the following error after applying a 'activity access = flag' filter:

warning: Invalid argument supplied for foreach() in /Users/thomascermak/Sites/londonfuse/sites/all/modules/activity/views/activity_views_handler_filter_access.inc on line 64.

Hi all,

What is the status of the patch for 2.x? I ask because I tried installing the latest versions of flag and activity (both 2.x-dev) and applying the patch in #13 but get the error:

"The patch seems outdated! The file line
}
and the patchline
$output .= theme('table', $header, $rows);
do not match!"

Any ideas?

Thanks in advance.

As well as this, when using TortoiseMerge, I see two patches on the left. One is named flag.module, the other is "null" (please see the attached screenshot)...

Hi Scott,

I know you're probably super busy. But any possible update on this? This type of feature could do wonders for one of my sites.

Thanks so much,

Thomas

I feel stupid. Thanks Scott.

this just made my day - really powerful stuff, wow! Big THANKS for the module to Scott, the patch to Scott & contribs!

Definitely working fine here. This should go in the dev.

Erg. RTBC patches that DON'T APPLY drive me nuts. This patch has been broken for the last month since #397464: Action for executing a flag was committed. I assume the users confirming this works were either using an earlier 2.x version or the 1.x version.

Anyway, other than that I agree that this patch is ready to go. So after a reroll and adjusting for the changes to the trigger integration, this is committed. Thanks Scott Reynolds for your work on this feature.

Attached patch that was committed.

mee -feed / you feed issue resolved, see here http://drupal.org/node/396960#comment-2227106

Ya, I haven't tested on the latest dev.

Subscribing...

I just wanted to add in case BenK was interested that I've tested this thoroughly the latest devs of both flag and Activity 2.x and the integration works just as desired.

Great please roll in to latest dev for more to try out with more ease!

Im not sure if your plans cover my issue, I would like to add flags to activity streams, just like with facebooks 'like'. It does not seem to be possible as activity feeds are not actually nodes.

Yes subscribe, thx ..

Is it possible to 'flag' an activity .. so not node or user, but the activity itself, same as 'I Like' in Facebook .. or am I missing something here :) ?

Liliplanet, that is an different request. Flag does not support flagging anything other than Users, Nodes, and Comments; though it's API allows the flagging of anything. No more types will be added directly to Flag module however, so flagging of activity items will need to be a separate module.

Do I still need to apply this patch or is it in any releases?

nvm got it working now.

This options doesn't seem to work with views3. New issue?

Yes, new issue.