Closed (won't fix)
Project:
Views (for Drupal 7)
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
18 Jun 2009 at 19:27 UTC
Updated:
1 Dec 2009 at 20:54 UTC
Jump to comment: Most recent file
Comments
Comment #1
dawehnerWhy not even bring this into the views module? I guess its often used
Comment #2
merlinofchaos commentedOk, committed to Views and moved to Documentation queue to handle archiving or editing the old documentation. It may still be valuable as an example of how to manipulate a view even with that function available in Views.
Comment #3
jhodgdonThanks. The old doc page has been archived.
Comment #4
bricel commentedI've modified the patch to improve DX :
- Changed the function signature to include args = array() .
- Removed some unneeded code fetching arguments.
- Fixed the documentation to comply with Drupal standards.
Comment #5
merlinofchaos commentedNote that changing $args to an array makes the signature differ from views_embed_view() -- I'm not sure that's a good thing.
Comment #6
dawehnerYes thats exactly what i thought.
Decide which is more friendly for the developer :) i think the first one.
Comment #7
jhodgdonComment #8
amitaibu@dereine,
I think the 2nd option (with the array) is better DX. Just by looking at the function's signature one can know $args can be passed. Currently, they should look into the code and see the func_get_args(), and understand from that they can pass args.
Comment #9
merlinofchaos commentedRegardless, consistency with an existing very similar function matters, even if one format may be marginally better. The consistency is more important, and Views is already inconsistent enough, thankyouverymuch =)
Comment #10
amitaibuOk, I agree that consistency wins in this case, so "won't fix".