Change user-inputted address (or lat/lon) to geocoded address info

Excellent work! This is a critical feature for getting reverse geocoding to work in Location module, as is necessary for using Location with FeedAPI content, for example.

However, the patch did not work for me "out of the box". I had to make some heavy modifications to it just to get it to apply at all, and then I had to modify it more so that it would actually submit reverse geocoding requests to Google's geocoder when saving a location. Probably tomorrow I will post my modifications once they have been made live on my organization's site.

I should be adding in a field in the content types interface to specify whether you want regular geocoding or reverse geocoding on the Location field of a given content type, as well as adding in the latitude & longitude query string parameters to the google geocoder code to make the reverse geocoding work properly.

By the way, I initially saw this issue in a response to another issue. Would you might referencing that one here so we could track the progress of both together?

The scope of my patch might be larger than yours, I've realized, so if you think I should open a new issue for my patch, let me know.

I would say that your patch needs work though because I couldn't get it to apply - it said was malformed.

Rather than go into a long explanation of what I would like to see, here is the patch that I've created. It's in two parts, because it was easier for me to make that way. I don't think I made part 2 from the proper directory, so you'll have to specify which file to patch. Anyway, though, it does work.

Essentially, the way it works is to do reverse geocoding (get an address from a latitude/longitude) if the latitude & longitude are changed. Otherwise, it does regular geocoding. That was in line with my use case (getting location data for items imported via FeedAPI, where the feed just had latitude/longitude).

It's not exactly what you were going for, though, I think, so it might actually be more appropriate in the other issue rather than this one. I'll post over there also & see what people think.

I dont have the patching functionality on my pc so can I request that the patched module be pasted here please or else if someone can tell me a simpler way to patch this in Windows (without needing to instal eclipse) then that would be appreciated

manuj_78:

I would recommend you download Cygwin - it's a bash shell emulator for Windows. That will allow you to apply patch files as you would on Unix. I think there's a few more suggestions at http://drupal.org/patch/apply.

After the patch in #6 I get Fatal error: Call to undefined function location_load_locations() in C:\Users\name\Sites\acquia-drupal-site\acquia-drupal\sites\all\modules\location\location_node.module on line 38

This is a test windows pc
I have not applied any other patches.

My patch only does reverse geocoding if the latitude & longitude are changed, although the conditional in the location.module could easily be changed so that it always did reverse geocoding.

I am not certain at this time what would be the best way to merge our two implementations. I didn't want to overwrite what users submitted into the location fields because I'm not sure how to determine what the accuracy is. Hopefully, some other people (such as geodaniel, the OP on the other issue) can comment & shed some light on the issue.

@manuj_78:
That is not happening for me when I save locations with this patch applied. Note that I actually applied the patch to 6.x-3.1-rc1.

I also have all the Location modules enabled, as well as Gmap module: Location, Location Add Another, Location CCK, Location Fax, Location Phone, Location Search, Node Locations, User Locations.

I don't think that enabling all of them should be necessary, however. The location_load_locations() function is defined in the location.module file.

Ok, cool. I think I get where you're coming from now, and I'm going to probably re-roll my patch in the next few days to make it apply better (& to be one patch). Then, I will move it over to #316297: Add a reverse lookup of the coordinates to obtain country and city (plus more?), which fits my use case better, and you can continue working on your approach in this issue. If our patches can ultimately meet in the middle, that's fine, but I think our approaches are different enough that for both of us to continue working in this issue will cause confusion.

So, how would I get this to reverse geocode my existing database of some 2000+ lat/longs in location, to add city state and zip code to existing locations?

EDIT: Is this patch needed to be able to map georss to feedapi/feedmapper_location (cck_location or location?) fields? Until now I am unsuccesfull in this..
Can anyone give the right steps from feedapi/feedelement_mapper feedelelement_location_mapper to get
the georss and other location related fields to location-fields?

greetings, Martijn

Sorry I haven't worked on this at all - I successfully used my patch in #6 to solve the use case I described. So I haven't had a need to work on it subsequently. If you can apply the patches & then tell me specifically issues that you encounter, I could try to help. But I won't have time to re-roll a patch on this in the near future.

has this been committed to dev yet?

@henno.gous: No, there would have to be a decision about which approach to take. Also, I don't think any of the maintainers (bdragon, ankur, YesCT (in effect)) have even seen this issue. You'd have to call it to their attention if you wanted something done, but I think that might be premature at this stage.

The patch is still at the "needs review" state. I recommend that you try it out if you need the feature. If we get a few reviews, and consensus that this is a good approach, then it can be marked "reviewed & tested by the community" and committed.

There's a stand alone module that does this task here. Still under development.

@furrymitn: Did you ever work further on your patch?

Here is a new version of my patch (as just one patch), rolled against 3.x-dev.

Let me know if it doesn't apply for you, and I can try to re-roll.

@Summit: For what you request in #16, you should look at the Location Feeds module.

I would like very much to "change user-inputted address (or lat/lon) to geocoded address info" via Ajax in Drupal 7. Is there anybody working on this at this time?

@Adam S: I've never done this via AJAX, or in D7 - I think that you could have a page callback that would call google_geocode_location() though, and then the response would be used to populate the regular location form.

I just ran into some issues with this code when trying to use it with Location Feeds module. See #1194588: $location['locpick']['user_latitude'] doesn't always override $location['latitude'] for an explanation. At some point, I may re-roll the patch, but I don't have time for now.

Another thing I noticed is that Google doesn't use "SubAdministrativeArea" in its JSON responses anymore apparently.

Thus, the last part of the google_geocode_location() function should now be:

  // Location data is returned as an associative array from the JSON response of the Google geocoder.
  return array(
    'lat' => $google_geocode_data['Placemark'][0]['Point']['coordinates'][1],
    'lon' => $google_geocode_data['Placemark'][0]['Point']['coordinates'][0],
    'geocoded_street' => $google_geocode_data['Placemark'][0]['AddressDetails']['Country']['AdministrativeArea']['Locality']['Thoroughfare']['ThoroughfareName'],
    'geocoded_city' => $google_geocode_data['Placemark'][0]['AddressDetails']['Country']['AdministrativeArea']['Locality']['LocalityName'],
    'geocoded_state' => $google_geocode_data['Placemark'][0]['AddressDetails']['Country']['AdministrativeArea']['AdministrativeAreaName'],
    'geocoded_country' => $google_geocode_data['Placemark'][0]['AddressDetails']['Country']['CountryNameCode'],
    'geocoded_accuracy' => $google_geocode_data['Placemark'][0]['AddressDetails']['Accuracy'],
    'geocoded_postalcode' =>$google_geocode_data['Placemark'][0]['AddressDetails']['Country']['AdministrativeArea']['Locality']['PostalCode']['PostalCodeNumber']
  );

@HLopes: Did you ever work further on your module?

all feature requests should be rolled against latest 7.x-3.x-dev and after commit can be backported to 6.x branch

Hi there,

no, never worked on it again. Had a couple persons asking me to take ownership of the module, but after that never heard from them again.

The last version had some actions available to mass reverse geocode nodes in a sub-module, and it's available in my sandbox.

http://drupalcode.org/sandbox/HLopes/1078432.git/commit/bd510dc

As for the D7 port, should be pretty straightforward, except for the actions bit.

Maybe i'll have some time to fiddle with this soon. Will report back if i do.

(that's some serious necro-posting :D )