nodevote won't work with paging.module

One option is to have a settings that would say "put vote on top" or "put vote on bottom".
If it is on the top, it would be visible in the first page.

Not sure if that would cover all cases or not.

Patches and ideas welcome.

Setting priority to normal.

The problem here is that the paging_nodeapi is called with the $op='load' before the nodevote_nodeapi $op='view' is called. The paging_nodeapi $op='load' breaks up the body into pages and saves it into the $node->pages[] array. The paging_nodepai $op='view' replaces the $node->body with $node->pages[$from]. In effect, it bypasses the addition of the nodevote information saved in $node->body. I resolved it this way by adding to nodevote_nodeapi to detect $node->pages_count and modify $node->pages instead of $node->body.

function nodevote_nodeapi(&$node, $op, $teaser, $page) {
global $user;
switch($op) {
case 'load':
if (variable_get(NODEVOTE_TYPE . $node->type, '0')){
if (_nodevote_vote_is_visible($node)) {
$extra['nodevote']->vote_display = 1;
}
if (_nodevote_is_votable($node)) {
$extra['nodevote']->vote_do = 1;
}
}
return $extra;
case 'view':
if (variable_get(NODEVOTE_TYPE . $node->type, '0')) {
if ($node->nodevote->vote_display) {
$vote = theme('nodevote_display_vote',$node->nid);
if ($page)
{
if ($node->pages_count) {
$node->pages[($node->pages_count - 1)] .= $vote;
}
else {
$node->body .= $vote;
}
}
else
{
$node->teaser .= $vote;
}
}
}

if ($page) {
if ($node->nodevote->vote_do) {
$vote = theme('nodevote_do_vote',$node);
if ($node->pages_count) {
$node->pages[($node->pages_count - 1)] .= $vote;
}
else {
$node->body .= $vote;
}
}
}
break;
case 'delete':
$r = db_query('DELETE FROM {nodevote} WHERE nid = %d', $node->nid);
break;
}
}

I have made the code test for $node->pages_count which is used by the paging module. I have tested this with another drupal install without the paging module. It works fine.

btw what is the proper patching format?

I have made the patch against the version of 4.7 released on 8/31/2006. Since I am not using 4.7, I did not test it. The change is only to check for the $node->pages_count variable and to add the voting information to the $node->pages instead of the $node->body. Since when paging module is used, the display is from $node->pages instead of $node->body.