I have an attribute with two options, the default option adds 0.- to the product price the other 200.-
(doesn't matter if displayed as "Checkboxes" or "Select box")

With "Store owner will enter prices inclusive of VAT." enabled I see the correct "impact" of the second option displayed behind the option text ".....+€200.00". but when this option is selected and the product is added to the cart the final price is x+232.- which means that a VAT of 16% has just been added to the option even tough it was already meant to be including VAT.

Note: this could be related to #485606: Not utilizing new price handler functionality on attribute level

Comments

longwave’s picture

Are you using uc_aac module? If so, are the prices and cart totals correct if you disable uc_aac?

xibun’s picture

after disabling uc_aac still the same problem.

as a bonus I also tried with uc_ajax_cart disabled - but again: still the same problem.

ckidow’s picture

Same thing here... subscribing

longwave’s picture

Status: Active » Fixed

Fixed in CVS. Attribute prices were always treated as exclusive of VAT before, so entering them inclusive of VAT meant that VAT was effectively added twice. This has been fixed for product attribute dropdowns and product and product class attribute/option pages.

Before attributes are attached to a particular product or class, it's unknown whether the product they will eventually be added to will include VAT or not, so these prices must always be entered exclusive of VAT. A note has been added to these pages informing the store owner of this.

xibun’s picture

Status: Fixed » Needs work

Hi again, I believe one small issue remains:
when displaying the attribute options as "Select box" or "Radio buttons" then the "impact" of the second option displayed behind the option text shows ".....+€172.41" (excl VAT). on the other hand when choosing the display type "Checkbox" it correctly shows "....+€200.00" (incl VAT).

longwave’s picture

uc_attribute uses the same code whether it is displaying select boxes, radio buttons or checkboxes, so I'm not sure why this isn't working in all cases. I will try to find time to investigate this soon.

longwave’s picture

Status: Needs work » Postponed (maintainer needs more info)

I've just done some tests on this and can't reproduce your issue - prices are displayed correctly on select boxes, radio buttons and checkboxes.

xibun’s picture

I played with it again and I still have it.

@CKIDOW can you try the following?
1. in "Store administration > Configuration > Tax rates and settings - enable "Store owner will enter prices inclusive of VAT."
2. add a "TESTprod" product with sell price of €100.-
3. add an attribute "TESTattr" with two options "OPT1" with price €0.- the other "OPT2" with price €10.-
4. add the attribute "TESTattr" to the "TESTprod" product
5. check the price behind "OPT2" for different display options. I see €10.00 for "Radio buttons" and "Select box" and €11.60 for "Checkbox".

-> my question: can you confirm what I see or does it have to do with my installation?

(note: even tough with radio buttons the price behind OPT2 shows +€10.00 and the base product price is €100.00 - when I add it to the cart it shows €111.60 once it's there)

longwave’s picture

Maybe it's a caching issue from the previous version of the module that had no attribute support? Either flush all caches with devel module, or try disabling "Cache generated price values until the next cron run" at /admin/store/settings/price-handlers and see if that makes a difference.

xibun’s picture

tried both now as suggested: flushed all caches (using admin menu) and disabled the "cache generated price values until the next cron run". no change, still have the same inconsistency. about the description in #8: I wrote it while I tried it myself, so what I saw (again) was based on fresh data. let me know when you have more ideas for tests.

longwave’s picture

StatusFileSize
new29.74 KB
new54.98 KB

I've tried again to reproduce this and it still works okay for me. Please see the attached screenshots for my test product options page and node view. Can you take similar screenshots of the pages where you are seeing this?

longwave’s picture

StatusFileSize
new23.63 KB

Also attached is the breakdown of the prices from the checkout page.

xibun’s picture

StatusFileSize
new24.2 KB
new23.16 KB
new50.66 KB

I would expect Button 2 to display "Button 2, +€11.60". same problem with Select, the second option right now shows "Select 2 +€10.00" instead of "Select 2 +€11.60".
(how do you take a screen shot with the select box open in Firefox 3.0.11 / Ubuntu 9.04? my usual method didn't work).

xibun’s picture

Status: Postponed (maintainer needs more info) » Fixed

after more checking just now I saw that there is a new dev version of uc_vat from yesterday. so I updated to see if this makes a difference. it doesn't.

BUT: after updating, running cron and flushing cache I went back to the browser window with the product view and hit refresh. and by chance I observed that behind the radio Button 2 the price was correctly +€11.60 for a split second and then changed to +€10.00. so feels like an ajax originated problem. and it is.

for the remaining problem I experience here it's enough to disable uc_aac. therefore I tag this fixed for uc_vat. and open a new issue over at uc_aac.

many thanks for the help longwave.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.