#slogan {layout.css?m (line 14)
  display:block;
}

Really?
This makes it go under the logo and it looks pretty ugly.

Comments

psynaptic’s picture

psynaptic commented

What else do you suggest?

This is one of those things that gets changed on every site. Is there a better default?

joachim’s picture

joachim commented

Well if we want a block, let's use a DIV.
If we want a SPAN, let's leave it inline to flow after the site title or something.
At the moment we have a sort of mishmash that has to be changed no matter what you want.

psynaptic’s picture

psynaptic commented

Well my thoughts were that the themer might want to use block or inline so they could set this without editing the markup.

joachim’s picture

joachim commented

In which case they'd probably need to enclose it in a DIV (do we have that?) or pull it into the H1 tag.
I'd say stick it in a DIV and place it directly beneath the site title.

psynaptic’s picture

psynaptic commented

I'm happy to go with what you say but is it really semantically correct to put something in a div because you want to to break onto a new line?

joachim’s picture

joachim commented

Well anything that is meant to be laid out as a block should really be a block element, so either P or DIV in this case.
That's the simplest thing to do, therefore the easiest to change.

psynaptic’s picture

psynaptic commented

Ok cool, sounds fine.

Would you mind committing?

joachim’s picture

joachim commented

Uh I was wrong -- actually, we have this:

<div id="header">
<a id="logo" href="/drupal-p3-gt-corp/"></a>
<a id="site-name" href="/drupal-p3-gt-corp/"> GTF corporate </a>
<span id="slogan">slogan!</span>
</div>

So they're all inline elements.
The least amount of change here is to just remove the display:block on the slogan. Then it runs in and looks ok :)
Let's not get fancy with layout -- most people will want to completely change the header layout anyway.

psynaptic’s picture

psynaptic commented

Agreed.

joachim’s picture

joachim commented
Status: Active » Fixed

Done.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.