I'm confused about this. Having a 700 and a 710 just doesn't look healthy to me:

.two-sidebars #centre {
  width: 500px;
}

.sidebar-left #centre {
  width: 710px;
  padding-right: 0;
}

.sidebar-right #centre {
  width: 700px;
}
CommentFileSizeAuthor
#4 clean_column_padding_496266.patch692 bytesjoachim

Comments

joachim’s picture

joachim commented

Yeah, you've basically got 20px instead of 10 between the centre and the right sidebar region.

Is it worth fixing this, or should we switch to use the 960 framework?
Even if we stay with the current approach, I'd be in favour of changing the width to 960px anyway as it divides more nicely than 910.

joachim’s picture

joachim commented
Category: task » bug
psynaptic’s picture

psynaptic commented

We should fix the bug in Clean and add 960 as an extra. I don't usually work to grids any more since I always get a design send over by a designer who doesn't use grids.

I've used them before and if I was doing the design I would use a grid so I'd be more than happy to add it as an extra but not to completely take over as that is provided by other modules already.

joachim’s picture

joachim commented
Status: Active » Fixed
StatusFileSize
new clean_column_padding_496266.patch692 bytes

Committed the following patch after testing with all column combinations.

psynaptic’s picture

psynaptic commented

Awesome, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.